Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:96517 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 58278 invoked from network); 20 Oct 2016 11:41:55 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 20 Oct 2016 11:41:55 -0000 Authentication-Results: pb1.pair.com smtp.mail=php@beccati.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=php@beccati.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain beccati.com designates 176.9.123.236 as permitted sender) X-PHP-List-Original-Sender: php@beccati.com X-Host-Fingerprint: 176.9.123.236 box.beccati.com Received: from [176.9.123.236] ([176.9.123.236:51572] helo=box.beccati.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 4A/36-24564-08DA8085 for ; Thu, 20 Oct 2016 07:41:54 -0400 Received: from authenticated-user (box.beccati.com [176.9.123.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by box.beccati.com (Postfix) with ESMTPSA id 53CE3200206; Thu, 20 Oct 2016 13:41:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=beccati.com; s=mail; t=1476963709; bh=WpTniiaOG9/ODvqx3dHjeagm4PcnZxZp0lxTZYsR2Ig=; h=Subject:To:References:From:Date:In-Reply-To:From; b=j7puz6HdM6CmFb3H3/egCcNs4K7W4tSw1xq6ZfMbqlW6L1MTANjYDbznqeJa0r+kh gLgWKqwUgWagESfh+raOnWE87mA4gUkG9O6amhsGsKhX5YFrj7ZcxxVQWIdOZOm+JW 2qpoZxsmsZoTihawrc1Kg9hZTIZliHNDOD4msCb94xz1sEYLBX/Wt3on3iEjjJQwmi EZg3037gnugtjW6o4cdfBOGegyuXrsv7Mm4kZ5HNSLTBiuGgtDL0UpBcYHBP156pNH 0PoEBXWPe9AsofiLgVzfE6znIXzeKS8XDof2rkCslyQvdJJsocsWTjA1v0oN6eYpZp AUEZAWjgT2K6A== To: Adam Baratz , "internals@lists.php.net" References: Message-ID: Date: Thu, 20 Oct 2016 13:41:44 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [RFC] Driver-Specific PDO Param Types From: php@beccati.com (Matteo Beccati) Hi Adam, On 19/10/2016 00:05, Adam Baratz wrote: > I've created an RFC to change how types are defined in PDO: > https://wiki.php.net/rfc/driver-specific-pdo-param-types > > Please share your feedback. I'm happy to hear thoughts about the pdo_dblib > example, but the RFC is more about the possibility of driver-specific types > than these particular ones. I've had a cursory look. Looks good to me and it doesn't impact the other drivers. One little nitpick is that technically the PDO_PARAM_INPUT_OUTPUT flags is now in the PDO_PARAM_DRIVER_SPECIFIC range and you add custom flags that one day might overlap with newly added generic ones. So maybe we need two driver specific ranges, e.g. PDO_PARAM_DRIVER_SPECIFIC = 1000, /* magic flag to denote a parameter as being input/output */ PDO_PARAM_INPUT_OUTPUT = 0x00010000 /* this defines the start of the range for driver specific flags */ PDO_PARAM_DRIVER_SPECIFIC_FLAG = 0x01000000 Since you're changing the API number, it shouldn't be a problem to modify PDO_PARAM_INPUT_OUTPUT, and this should leave plenty of room for new generic flags and both driver specific params and flags. Cheers -- Matteo Beccati Development & Consulting - http://www.beccati.com/