Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:96502
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain ohgaki.net designates 180.42.98.130 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <088801d229fa$d7320cb0$85962610$@belski.net>
References: <CAGa2bXYg1kkoYGQNr8T2oTshuqrvweefYO+EdY41w1vwUM32iQ@mail.gmail.com>
 <CAGa2bXZLB6SsC3FQyntaDy93YfG5rDigJH6GpC5dF7MZJuJ=LQ@mail.gmail.com>
 <CAGa2bXaM_rSbmSx_bPE4erG6ok1KLdXSqnJP5ngxUNBsrzu0pw@mail.gmail.com>
 <CAPwsocHhsm9Zrh=rpF=Pbct6t5wKfAa-wirGfGjmxV8pi4nttw@mail.gmail.com>
 <CAGa2bXaMMaZn1GyrnT6Bgz3xCMDkFs+YNwHoNZe_1ge5LjLPDg@mail.gmail.com>
 <CAPwsocHXhpQNCYXVN0DHj77M0cA3eAgKuStOPquNUjx=46W1Mw@mail.gmail.com>
 <CAGa2bXaEyd+Qcc7EAQwTEVJY-zD_cK37AYXfM_534YesBG0xOA@mail.gmail.com>
 <CAPwsocHqbeYw=2S6EZG+5zUEWMSM5V2OoG9uLO05sbQffJ1GPw@mail.gmail.com>
 <CAGa2bXZGWFW1gXx4uuAehw0MGADWPMXVuD7wsSJuAQ6f6HJv6A@mail.gmail.com>
 <CAGa2bXZ1wGO_x4z5agJ0+uWX4xfuOYX1or4KziwbMa9v_+-JxA@mail.gmail.com>
 <CANUQDCh9RSnOs__c4crYsH44z0L-mHkTTCgAn-d1bSgH09yL0w@mail.gmail.com>
 <CAGa2bXbDR4EnSU0UUMQR4OGaEAJGPkf7s9M+56CyCPvJ=XSbUQ@mail.gmail.com>
 <CANUQDChPsJHZ73=ke_yo+Pbu2B8rRcFrUYZWJiD5TrwECY4hEA@mail.gmail.com>
 <CAGa2bXZ98ZKER2hRp=2pvTYGVLGXFzkdefFfoERojgQvarHUBw@mail.gmail.com>
 <070001d2295e$76b7d730$64278590$@belski.net> <CAGa2bXYMTKLLGggq34P-zGF+MePc7BnFcTomjY+k+bNRzNhacw@mail.gmail.com>
 <075a01d22993$9efc6c80$dcf54580$@belski.net> <CAGa2bXYzFpHcyKS2xxG6HN2w2+UDfSPQv3E1816ub-Pkp=54Cw@mail.gmail.com>
 <088801d229fa$d7320cb0$85962610$@belski.net>
Date: Thu, 20 Oct 2016 16:18:58 +0900
Message-ID: <CAGa2bXZ3A_GqhXQ4Dw4WMDHrJMsCrydiHp4EG0EPH=5NsOm4gA@mail.gmail.com>
To: Anatol Belski <anatol.php@belski.net>
Cc: Joe Watkins <pthreads@pthreads.org>, Niklas Keller <me@kelunik.com>, Leigh <leight@gmail.com>, 
	PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Re: [RFC][DISCUSSION] Improve uniqid() uniqueness
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

Hi Anatol,

On Wed, Oct 19, 2016 at 8:20 PM, Anatol Belski <anatol.php@belski.net> wrot=
e:
>> I won't have time to write RFC for this, probably. I have many other thi=
ngs that I
>> would like to improve, like session error status handling improvement th=
at I
>> recently proposed.
>>
> I see. It's a pity you won't have time to write an RFC. I see one already=
 in place on the wiki though. I see also your several other patches hanging=
 on gihtub. IMHO it is a real waste of time to abandon the work you've done=
, without really pulling it through. With uniqid(), maybe it'd be even the =
right decision to return to your original RFC, or just to reduce it to comp=
ly with the simple patch variant. I'm sure, that no one wants to lose the g=
ood contributions, even though it might take some effort to reach the commo=
n ground sometimes.

I meant I wouldn't have time for RFC only replace php_combined_lcg().
I'll address uniqid() improvement sometime in the future.

To all,

We constantly get "uniqid() is not unique" bug reports.
In the meantime, any objection for adding following note to uniqid() manual=
.

"Do not make assumption for uniqid() output format, entropy
especially. uniqid() output format may be changed to provide
reasonably unique ID in future versions."


Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net