Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:96475 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 44034 invoked from network); 19 Oct 2016 12:08:38 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 19 Oct 2016 12:08:38 -0000 Authentication-Results: pb1.pair.com header.from=yohgaki@ohgaki.net; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=yohgaki@ohgaki.net; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain ohgaki.net designates 180.42.98.130 as permitted sender) X-PHP-List-Original-Sender: yohgaki@ohgaki.net X-Host-Fingerprint: 180.42.98.130 ns1.es-i.jp Received: from [180.42.98.130] ([180.42.98.130:43542] helo=es-i.jp) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id A1/A4-14749-34267085 for ; Wed, 19 Oct 2016 08:08:36 -0400 Received: (qmail 56987 invoked by uid 89); 19 Oct 2016 12:08:30 -0000 Received: from unknown (HELO mail-qk0-f180.google.com) (yohgaki@ohgaki.net@209.85.220.180) by 0 with ESMTPA; 19 Oct 2016 12:08:30 -0000 Received: by mail-qk0-f180.google.com with SMTP id n189so30865415qke.0 for ; Wed, 19 Oct 2016 05:08:29 -0700 (PDT) X-Gm-Message-State: ABUngvcwmKC/84eZXypSrUkYMTVdtezro92ItszN/OFCyI7ge5xX/AvPoNoC7KPP8FSpO0o7sY1aSyFrQvbSgg== X-Received: by 10.55.177.5 with SMTP id a5mr5575525qkf.153.1476878903726; Wed, 19 Oct 2016 05:08:23 -0700 (PDT) MIME-Version: 1.0 Received: by 10.140.22.38 with HTTP; Wed, 19 Oct 2016 05:07:43 -0700 (PDT) In-Reply-To: References: <1d22f996-27b6-35bb-03a6-df3acf9e33d4@gmail.com> Date: Wed, 19 Oct 2016 21:07:43 +0900 X-Gmail-Original-Message-ID: Message-ID: To: Davey Shafik Cc: Stanislav Malyshev , "internals@lists.php.net" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] Re: Fixing insane session_start() behaviors From: yohgaki@ohgaki.net (Yasuo Ohgaki) Hi Davey, On Wed, Oct 19, 2016 at 6:06 PM, Davey Shafik wrote: > Yasuo, assuming "partial fix" doesn't mean "broken fix" but instead "it > doesn't do everything I planned" then I do not want this in 7.1. As other= s > have pointed out, it's not a small change and sessions are a fundamental > part of PHP =E2=80=94 we are simply too far into the release cycle to inc= lude this. > > Please target 7.2/master. OK. I'll merge this to master. Partial fix is done so that it does not break internal API signatures. It's fixed as plain bug fix. PHP 7.1's session_start() sets a little better session status and 'FALSE' than older PHP, but it's far from correct/reliable. I'll update UPGRADING comment. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net