Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:96466
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.174 as permitted sender)
To: Yasuo Ohgaki <yohgaki@ohgaki.net>, Davey Shafik <davey@php.net>,
 "internals@lists.php.net" <internals@lists.php.net>
References: <CAGa2bXYq=656z9eq-b=agpqJmojDn+DpDt1zfLLc_QTcFcLt8g@mail.gmail.com>
 <CAGa2bXaGg0PocgtJEQ2Xhi6Us4F=ncEN-6zhZKEjGE1UuSoQ5A@mail.gmail.com>
Message-ID: <1d22f996-27b6-35bb-03a6-df3acf9e33d4@gmail.com>
Date: Tue, 18 Oct 2016 23:08:49 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0)
 Gecko/20100101 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <CAGa2bXaGg0PocgtJEQ2Xhi6Us4F=ncEN-6zhZKEjGE1UuSoQ5A@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Re: Fixing insane session_start() behaviors
From: smalyshev@gmail.com (Stanislav Malyshev)

Hi!

> I pushed patch fixes number of nonsense/inconsistent session function
> behaviors. The additional patch is pushed so that it's easy to cherry
> pick minimum fixes. The last push is the additional fixes.

These changes look like a reasonable cleanup. I'm not a big fan of
zend_parse_parameters_none additions, since I don't see any useful
function for them, but they don't hurt either. I left some notes on the
patch though, please look there.

I'm not sure about 7.1 - while I don't see anything that would break any
reasonable code, except issues noted on the pull, the patch is pretty
big and I might have missed something. I guess it's for RM to decide. No
objection for 7.2.

I notice that most test changes deal with scenarios that were covered
before, are there tests that test the new things - the scenarios for
which handling has changed? I couldn't find tests for some cases, like
INI modification, would be nice to add them.

Also, a reminder that you'd have to update all the documentation in the
manual to reflect the change in the return values. And UPGRADING too.
-- 
Stas Malyshev
smalyshev@gmail.com