Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:96430 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 17706 invoked from network); 18 Oct 2016 12:03:52 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 18 Oct 2016 12:03:52 -0000 Authentication-Results: pb1.pair.com header.from=yohgaki@ohgaki.net; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=yohgaki@ohgaki.net; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain ohgaki.net designates 180.42.98.130 as permitted sender) X-PHP-List-Original-Sender: yohgaki@ohgaki.net X-Host-Fingerprint: 180.42.98.130 ns1.es-i.jp Received: from [180.42.98.130] ([180.42.98.130:40646] helo=es-i.jp) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 61/FC-40890-5AF06085 for ; Tue, 18 Oct 2016 08:03:52 -0400 Received: (qmail 89630 invoked by uid 89); 18 Oct 2016 12:03:45 -0000 Received: from unknown (HELO mail-qk0-f170.google.com) (yohgaki@ohgaki.net@209.85.220.170) by 0 with ESMTPA; 18 Oct 2016 12:03:45 -0000 Received: by mail-qk0-f170.google.com with SMTP id z190so287703927qkc.2 for ; Tue, 18 Oct 2016 05:03:44 -0700 (PDT) X-Gm-Message-State: AA6/9RkxOUK/7GBq0N6gJbnuXJ7Fqf10YyWLeWxdT3d218t2bhLBQEllhZ8je3M1/5AY1hOUAtJkt6xudVj8mA== X-Received: by 10.55.114.131 with SMTP id n125mr49288qkc.17.1476792218568; Tue, 18 Oct 2016 05:03:38 -0700 (PDT) MIME-Version: 1.0 Received: by 10.140.84.168 with HTTP; Tue, 18 Oct 2016 05:02:57 -0700 (PDT) In-Reply-To: References: Date: Tue, 18 Oct 2016 21:02:57 +0900 X-Gmail-Original-Message-ID: Message-ID: To: Joe Watkins Cc: Niklas Keller , Leigh , PHP Internals Content-Type: text/plain; charset=UTF-8 Subject: Re: [PHP-DEV] Re: [RFC][DISCUSSION] Improve uniqid() uniqueness From: yohgaki@ohgaki.net (Yasuo Ohgaki) Hi Joe, On Tue, Oct 18, 2016 at 8:30 PM, Yasuo Ohgaki wrote: > > On Tue, Oct 18, 2016 at 7:32 PM, Joe Watkins wrote: >>> This change should go through the standard RFC process and should be >>> targeted at 7.2+ (master) *only*. >> >>> Please check with the RMs before merging functionality changes into >>> release >>> branches. All functionality changes need consent and consensus. Bug fixes >>> (that don't change functionality or break BC) do not. >> >> You were told very specifically that the kinds of changes you proposed here >> require an RFC. > > This comment is for original proposal that _changes_ output format, isn't it? > > It simply switches entropy source which we already relied on. As you can see from last minutes discussion. "/dev/urandom cannot be read" is FUD. It's pure bug fix. (I intentionally made patch easy to extend used chars, though) Would you consider revert the revert? Thanks. -- Yasuo Ohgaki yohgaki@ohgaki.net