Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:96423 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 4260 invoked from network); 18 Oct 2016 11:09:25 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 18 Oct 2016 11:09:25 -0000 Authentication-Results: pb1.pair.com smtp.mail=yohgaki@ohgaki.net; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=yohgaki@ohgaki.net; sender-id=pass Received-SPF: pass (pb1.pair.com: domain ohgaki.net designates 180.42.98.130 as permitted sender) X-PHP-List-Original-Sender: yohgaki@ohgaki.net X-Host-Fingerprint: 180.42.98.130 ns1.es-i.jp Received: from [180.42.98.130] ([180.42.98.130:40486] helo=es-i.jp) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id BD/2A-40890-0E206085 for ; Tue, 18 Oct 2016 07:09:24 -0400 Received: (qmail 80778 invoked by uid 89); 18 Oct 2016 11:09:17 -0000 Received: from unknown (HELO mail-qt0-f172.google.com) (yohgaki@ohgaki.net@209.85.216.172) by 0 with ESMTPA; 18 Oct 2016 11:09:17 -0000 Received: by mail-qt0-f172.google.com with SMTP id f6so153417308qtd.2 for ; Tue, 18 Oct 2016 04:09:16 -0700 (PDT) X-Gm-Message-State: AA6/9RkilJTxkbRtUQgPeXViteq53JvZXtt+7DKS6j5cYiuKHBnIivuRaNgCCzHQolwhQJZcB56McPRlnyoopA== X-Received: by 10.237.56.34 with SMTP id j31mr1826239qte.16.1476788950383; Tue, 18 Oct 2016 04:09:10 -0700 (PDT) MIME-Version: 1.0 Received: by 10.140.84.168 with HTTP; Tue, 18 Oct 2016 04:08:30 -0700 (PDT) In-Reply-To: <1D4E0886-5DE1-403F-98C5-8C4B8CC5E8EF@bobs-bits.com> References: <1D4E0886-5DE1-403F-98C5-8C4B8CC5E8EF@bobs-bits.com> Date: Tue, 18 Oct 2016 20:08:30 +0900 X-Gmail-Original-Message-ID: Message-ID: To: Stephen Reay Cc: "internals@lists.php.net" , Davey Shafik , Xinchen Hui Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] header() removes all header of the same name. From: yohgaki@ohgaki.net (Yasuo Ohgaki) Hi Stephen, On Tue, Oct 18, 2016 at 5:54 PM, Stephen Reay wrote= : > If the replace flag was fixed, isn=E2=80=99t this then just a case of mak= ing sure userland sets replace to false if they want existing set-cookie he= aders retained? Yes and no. If users use the replace flag correctly, then it will work. However, I don't expect users set replace flag correctly. If replace flag's default was opposite, it would work better. > Removing the ability to write a custom Set-Cookie header introduces a big= ger problem than the current one, IMO. OK. Let's just fix the replace flag and document removing 'Set-Cookie' header by header() may result in unwanted results. Everyone is ok with this? Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net