Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:96397
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain belski.net from 85.214.73.107 cause and error)
To: "'Andrea Faulds'" <ajf@ajf.me>,
	<internals@lists.php.net>
References: <alpine.DEB.2.20.1610071530340.3648@whisky.home.derickrethans.nl> <CAF+90c8F+jitXS4OGxy+b-BdhzdpGu3PvBhwB70eYLCFMqxohQ@mail.gmail.com> <CANaX5ndw-aTtAwepCNX90TzFdmX8dv3yMpjRpD83Be746Umiyg@mail.gmail.com> <010701d2218e$b2e12d60$18a38820$@belski.net> <CABBJUpcMVArH67tUOrNtVrD5U_cTdkDiXhEuX5oqVvp0cwhBNw@mail.gmail.com> <002001d22223$23363300$69a29900$@belski.net> <CAF+90c8jGPGv4EvfRiABNSJqa2s8Q+UcBxJXRD7m8JH5_Wbu4Q@mail.gmail.com> <025201d2259a$21e542f0$65afc8d0$@belski.net> <8d5a4bf7-3766-ae3c-400c-40b17df33a83@gmail.com> <23.53.00450.07315085@pb1.pair.com>
In-Reply-To: <23.53.00450.07315085@pb1.pair.com>
Date: Mon, 17 Oct 2016 21:33:32 +0200
Message-ID: <03a201d228ad$5aa5e340$0ff1a9c0$@belski.net>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQItOLydTqT+dIGA3YBv5mmFOlapewMWylwtAqhC8kICT73digIfoWNeAggouZUCTaNu1wJG0vmpAxAH+yoBscSI9J9KgZxQ
Content-Language: en-us
Subject: RE: [PHP-DEV] Regression between RC1 and RC2?
From: anatol.php@belski.net ("Anatol Belski")

Hi,

> -----Original Message-----
> From: Andrea Faulds [mailto:ajf@ajf.me]
> Sent: Monday, October 17, 2016 8:08 PM
> To: internals@lists.php.net
> Subject: Re: [PHP-DEV] Regression between RC1 and RC2?
>=20
> Hi Stas,
>=20
> Stanislav Malyshev wrote:
> > Hi!
> >
> >>> So the problem basically is that in PHP 7.0 both print_r and
> >>> var_dump directly print to output. This means that by the time the
> >>> exception is thrown, we've already written output. This makes it
> >>> unclear how exactly the exception should be handled. Is it okay to
> >>> just print everything and handle the exception afterward? This =
seems odd to
> me -- if an operation fails it shouldn't do anything.
> >
> > This sounds nice in theory, in practice often impossible. I.e. if =
you
> > already started printing and then some dependency fails, then you =
get
> > half-printed output. That's fine IMHO. Exception is not a normal
> > condition, so you get result which is not normal.
> >
> >>> In PHP 7.1 I've rewritten print_r() to use an internal buffer, so =
we
> >>> could handle this case completely gracefully. The same change =
could
> >>> be implemented for var_dump(). With this approach we'd only print
> >>> anything if no exception occurred.
> >
> > This is ok, but I don't think it's required. If you've got in
> > exception in conversion, all bets are off, any result that passes a
> > low sanity margin IMHO is ok - including both printing whatever
> > happened before the exception and not printing anything.
> >
>=20
> I also think that the exception firing mid-output isn't all that =
unreasonable. If you
> were to implement var_dump() or print_r() yourself in userland, and =
didn't
> explicitly handle this case, you'd get the same result, I imagine.
>=20
FYI the patch is now reverted also in the dev branches. The ticket =
https://bugs.php.net/bug.php?id=3D73067 is re-opened, as the discussion =
is continued.

Regards

Anatol