Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:96391 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 85103 invoked from network); 17 Oct 2016 09:48:17 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 17 Oct 2016 09:48:17 -0000 Authentication-Results: pb1.pair.com smtp.mail=yohgaki@ohgaki.net; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=yohgaki@ohgaki.net; sender-id=pass Received-SPF: pass (pb1.pair.com: domain ohgaki.net designates 180.42.98.130 as permitted sender) X-PHP-List-Original-Sender: yohgaki@ohgaki.net X-Host-Fingerprint: 180.42.98.130 ns1.es-i.jp Received: from [180.42.98.130] ([180.42.98.130:37065] helo=es-i.jp) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 3C/3C-59423-D5E94085 for ; Mon, 17 Oct 2016 05:48:16 -0400 Received: (qmail 100016 invoked by uid 89); 17 Oct 2016 09:48:09 -0000 Received: from unknown (HELO mail-qk0-f175.google.com) (yohgaki@ohgaki.net@209.85.220.175) by 0 with ESMTPA; 17 Oct 2016 09:48:09 -0000 Received: by mail-qk0-f175.google.com with SMTP id f128so215179714qkb.1 for ; Mon, 17 Oct 2016 02:48:09 -0700 (PDT) X-Gm-Message-State: AA6/9RkvuQ7D9+vNltH3wdxYyZ2LIG42AaA2cIky/0ijaCbMgnJKxeaPTANd4QFFu7dm+9IIQhfm9ODBkMe0Cg== X-Received: by 10.55.72.209 with SMTP id v200mr21913917qka.262.1476697682999; Mon, 17 Oct 2016 02:48:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.140.84.168 with HTTP; Mon, 17 Oct 2016 02:47:22 -0700 (PDT) In-Reply-To: References: Date: Mon, 17 Oct 2016 18:47:22 +0900 X-Gmail-Original-Message-ID: Message-ID: To: Davey Shafik , "internals@lists.php.net" Content-Type: text/plain; charset=UTF-8 Subject: Re: Fixing insane session_start() behaviors From: yohgaki@ohgaki.net (Yasuo Ohgaki) Hi Davey, On Sun, Oct 16, 2016 at 6:08 PM, Yasuo Ohgaki wrote: > > I was planning to fix session_start() behaviors by PHP 7.1, but I > forgot to do this completely. Partial fix is merged currently. > > Following PR makes session_start() return FALSE when it cannot start > session always. > > https://github.com/php/php-src/pull/2167 > > In short, this patch fixes number of session_start()'s insane behaviors. I think I've finished the patch for now. There are many other places that I would like to improve/fix error handlings. e.g. Session save handlers. This patch is too large already. I'll fix them in master. The patch could be divided into "session_start() error handling fix only" and "other session core error handling issues". It may be good to include "session_start() error handling fix only" for PHP 7.1, but other fixes won't bother correct PHP scripts. Please note that session_start() fix in PHP-7.1 and master branch is partial fix. I suggest to merge "session_start() error handling fix only" at least, but it's your choice. Please let me know when you decide what to do or merge appropriate patch from the PR. BTW, I expect UnitTest failures, framework/etc, that test session module functionalities. They have tests for failure cases. Even if there are minor BC issues (UnitTests report error, bad code emit errors), this fix must be done at some point anyway. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net