Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:96377
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.176 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAGa2bXYDvdEA_yv-y=BtyLFLBy6xJLrBK_HxbkhApqSVpkC0vg@mail.gmail.com>
References: <CAGa2bXYDvdEA_yv-y=BtyLFLBy6xJLrBK_HxbkhApqSVpkC0vg@mail.gmail.com>
Date: Sat, 15 Oct 2016 11:22:24 +0200
Message-ID: <CAF+90c_iZvFMuFM+aAmNbkpp5=CNQW8T4fT7qBT6O3=1CgkCkA@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=f403045dc87a79a1c2053ee3e1b0
Subject: Re: [PHP-DEV] Best practice of initializing zval array hash?
From: nikita.ppv@gmail.com (Nikita Popov)

--f403045dc87a79a1c2053ee3e1b0
Content-Type: text/plain; charset=UTF-8

On Sat, Oct 15, 2016 at 8:23 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:

> Hi all,
>
> I'm wandering what is the best practice of zval array hash initialization.
>
> Following code leaks 56 bytes on ZVAL_NEW_ARR()
>
> chash = php_mb_convert_encoding_recursive(HASH_OF(entry),
> _to_encoding, _from_encodings);
> if (chash) {
>   ZVAL_NEW_ARR(&entry_tmp); // _array_init() is called. Should leak by
> next line.
>   Z_ARRVAL(entry_tmp) = chash;
> }
>
> I thought there would be API that replaces or initialize ZVAL array
> hash to existing hash, but I couldn't find one. So I fixed above code
> like
>
> chash = php_mb_convert_encoding_recursive(HASH_OF(entry),
> _to_encoding, _from_encodings);
> if (chash) {
>   Z_TYPE_INFO(entry_tmp) = IS_ARRAY_EX;
>   Z_ARRVAL(entry_tmp) = chash;
> }
>
> I used IS_ARRAY_EX like ZVAL_NEW_ARR(). However, this code seemed a
> little strange to me, so I grepped source tree and found no other .c
> code uses IS_ARRAY_EX.
>
> What's the best practice for this?
>
> It seems API does not expect to replace zval array hash by existing
> hash. Should I pass entry_tmp to php_mb_covert_encoding_recursive()
> instead? i.e.
>
> ZVAL_NEW_ARR(&entry_tmp);
> php_mb_convert_encoding_recursive(HASH_OF(&entry_tmp), HASH_OF(entry),
> _to_encoding, _from_encodings);
>
> Thank you.
>

Are you looking for ZVAL_ARR()?

Nikita

--f403045dc87a79a1c2053ee3e1b0--