Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:96366
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmx.de designates 212.227.15.18 as permitted sender)
To: Kalle Sommer Nielsen <kalle@php.net>, Dan Ackroyd <danack@basereality.com>
References: <64abfe29-6d8d-c186-6e52-47fa9309bdb6@gmx.de>
 <CA+kxMuSkes_0aGV9xAP2tuJLxp_imLncp6kBovG-KzK4Zd6U-w@mail.gmail.com>
 <CAJW__o269DnL+Ym52evvTvXe86h-dbL8npRE6KHo31LmNFt-sQ@mail.gmail.com>
Cc: PHP internals <internals@lists.php.net>
Message-ID: <82aaf645-f60e-0d8c-ac14-055e4da62efb@gmx.de>
Date: Fri, 14 Oct 2016 10:48:20 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <CAJW__o269DnL+Ym52evvTvXe86h-dbL8npRE6KHo31LmNFt-sQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] ext/gd: Deprecate png2wbmp() and jpeg2wbmp()
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 14.10.2016 at 00:50, Kalle Sommer Nielsen wrote:

> 2016-10-13 23:17 GMT+02:00 Dan Ackroyd <danack@basereality.com>:
>
>> On 13 October 2016 at 18:03, Christoph M. Becker <cmbecker69@gmx.de> wrote:
>>
>>> Implementing a fallback in userland would be trivial
>>
>> You should do that first, and get at least some people to use them, if
>> you want them deprecated or removed from PHP.
> 
> I don't think this really matters for these so rarely used functions tbh

Indeed it might be hard to find people still converting to WBMP, let
alone finding someone who'd be willing to work with a fallback as long
as the functions are in ext/gd.  Furthermore a fallback might be as
simple as:

    if (!function_exists('png2wbmp')) {
        function png2wbmp(string $pngname, string $wbmpname,
                          int $dest_height, int $dest_width,
                          int $threshold)
        {
            $im = imagecreatefrompng($pngname);
            $width = imagesx($im);
            $height = imagesy($im);
            $tmp = imagecreate($width, $height);
            imagecopyresized($tmp, $im, 0, 0, 0, 0, $dest_width,
                             $dest_height, $width, $height);
            return image2wbmp($tmp, $wbmpname, $threshold);
        }
    }

In my opinion, there's no need for an external library.  The crux would
be image2wbmp(); if it won't get fixed, it can't be used here.  But in
this case I'd prefer a more general solution for converting to black and
white according to a given threshold.  That might be interesting for
other formats (e.g. PNG) as well.

-- 
Christoph M. Becker