Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:96361
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmx.de designates 212.227.17.21 as permitted sender)
To: Kalle Sommer Nielsen <kalle@php.net>
References: <64abfe29-6d8d-c186-6e52-47fa9309bdb6@gmx.de>
 <CAJW__o1z_=NUJyMdghUzR-X2kF7nnYwTe9T++YFT2hzMGjkiJw@mail.gmail.com>
Cc: PHP internals <internals@lists.php.net>
Message-ID: <b4f22a55-faca-1e5f-2396-0de8c01d1e0a@gmx.de>
Date: Fri, 14 Oct 2016 00:56:32 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <CAJW__o1z_=NUJyMdghUzR-X2kF7nnYwTe9T++YFT2hzMGjkiJw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] ext/gd: Deprecate png2wbmp() and jpeg2wbmp()
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 13.10.2016 at 22:28, Kalle Sommer Nielsen wrote:

> 2016-10-13 19:03 GMT+02:00 Christoph M. Becker <cmbecker69@gmx.de>:
>
>> I suggest to deprecate png2wbmp() and jpeg2wbmp() as of PHP 7.2 and to
>> remove the functions as of PHP 8.0.
>>
>> Both functions are very special for ext/gd; there are no other direct
>> conversion functions, and even their names do not start with "image"
>> like all other ext/gd functions, except gd_info().  Implementing a
>> fallback in userland would be trivial (besides an issue with
>> image2wbmp(), see <https://bugs.php.net/bug.php?id=73317>).
>> Furthermore, WBMP supposedly isn't really important nowadays.
> 
> +1, I even think that 7.3 should have them removed. 

Frankly, I think these functions should have been removed with PHP 7.0.
However, that didn't happen, and so we'd have to adhere to our release
process[1]:

 * x.y.z to x.y+1.z
   * API compatibility must be kept (userland)

> Besides png2wbmp()
> and jpeg2wbmp(), I'd like for you to add image2wbmp() to that list
> too.

Actually, I agree that we should remove this function.  However, it is
supposed to offer the easy fallback for the other functions, so keeping
it would be helpful to provide efficient userland replacements, if it
will be fixed[2].  Otherwise it's useless anyway, and we might consider
to introduce something like

  imagefilter($im, IMG_FILTER_BLACK_AND_WHITE, $threshold)

[1] <https://wiki.php.net/rfc/releaseprocess>
[2] <https://bugs.php.net/bug.php?id=73317>

-- 
Christoph M. Becker