Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:96356
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.176 as permitted sender)
To: Anatol Belski <anatol.php@belski.net>,
 'Nikita Popov' <nikita.ppv@gmail.com>
References: <alpine.DEB.2.20.1610071530340.3648@whisky.home.derickrethans.nl>
 <CAF+90c8F+jitXS4OGxy+b-BdhzdpGu3PvBhwB70eYLCFMqxohQ@mail.gmail.com>
 <CANaX5ndw-aTtAwepCNX90TzFdmX8dv3yMpjRpD83Be746Umiyg@mail.gmail.com>
 <010701d2218e$b2e12d60$18a38820$@belski.net>
 <CABBJUpcMVArH67tUOrNtVrD5U_cTdkDiXhEuX5oqVvp0cwhBNw@mail.gmail.com>
 <002001d22223$23363300$69a29900$@belski.net>
 <CAF+90c8jGPGv4EvfRiABNSJqa2s8Q+UcBxJXRD7m8JH5_Wbu4Q@mail.gmail.com>
 <025201d2259a$21e542f0$65afc8d0$@belski.net>
Cc: 'Xinchen Hui' <laruence@php.net>, 'Davey Shafik' <davey@php.net>,
 'Derick Rethans' <derick@php.net>,
 'PHP Developers Mailing List' <internals@lists.php.net>
Message-ID: <8d5a4bf7-3766-ae3c-400c-40b17df33a83@gmail.com>
Date: Thu, 13 Oct 2016 14:52:23 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0)
 Gecko/20100101 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <025201d2259a$21e542f0$65afc8d0$@belski.net>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Regression between RC1 and RC2?
From: smalyshev@gmail.com (Stanislav Malyshev)

Hi!

>> So the problem basically is that in PHP 7.0 both print_r and var_dump directly
>> print to output. This means that by the time the exception is thrown, we've
>> already written output. This makes it unclear how exactly the exception should
>> be handled. Is it okay to just print everything and handle the exception
>> afterward? This seems odd to me -- if an operation fails it shouldn't do anything.

This sounds nice in theory, in practice often impossible. I.e. if you
already started printing and then some dependency fails, then you get
half-printed output. That's fine IMHO. Exception is not a normal
condition, so you get result which is not normal.

>> In PHP 7.1 I've rewritten print_r() to use an internal buffer, so we could handle
>> this case completely gracefully. The same change could be implemented for
>> var_dump(). With this approach we'd only print anything if no exception
>> occurred.

This is ok, but I don't think it's required. If you've got in exception
in conversion, all bets are off, any result that passes a low sanity
margin IMHO is ok - including both printing whatever happened before the
exception and not printing anything.

-- 
Stas Malyshev
smalyshev@gmail.com