Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:96355
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain belski.net from 85.214.73.107 cause and error)
To: "'Nikita Popov'" <nikita.ppv@gmail.com>
Cc: "'Xinchen Hui'" <laruence@php.net>,
	"'Davey Shafik'" <davey@php.net>,
	"'Derick Rethans'" <derick@php.net>,
	"'PHP Developers Mailing List'" <internals@lists.php.net>
References: <alpine.DEB.2.20.1610071530340.3648@whisky.home.derickrethans.nl> <CAF+90c8F+jitXS4OGxy+b-BdhzdpGu3PvBhwB70eYLCFMqxohQ@mail.gmail.com> <CANaX5ndw-aTtAwepCNX90TzFdmX8dv3yMpjRpD83Be746Umiyg@mail.gmail.com> <010701d2218e$b2e12d60$18a38820$@belski.net> <CABBJUpcMVArH67tUOrNtVrD5U_cTdkDiXhEuX5oqVvp0cwhBNw@mail.gmail.com> <002001d22223$23363300$69a29900$@belski.net> <CAF+90c8jGPGv4EvfRiABNSJqa2s8Q+UcBxJXRD7m8JH5_Wbu4Q@mail.gmail.com>
In-Reply-To: <CAF+90c8jGPGv4EvfRiABNSJqa2s8Q+UcBxJXRD7m8JH5_Wbu4Q@mail.gmail.com>
Date: Thu, 13 Oct 2016 23:38:22 +0200
Message-ID: <025201d2259a$21e542f0$65afc8d0$@belski.net>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQItOLydTqT+dIGA3YBv5mmFOlapewMWylwtAqhC8kICT73digIfoWNeAggouZUCTaNu1598LkHA
Content-Language: en-us
Subject: RE: [PHP-DEV] Regression between RC1 and RC2?
From: anatol.php@belski.net ("Anatol Belski")

Hi Nikita,

> So the problem basically is that in PHP 7.0 both print_r and var_dump =
directly
> print to output. This means that by the time the exception is thrown, =
we've
> already written output. This makes it unclear how exactly the =
exception should
> be handled. Is it okay to just print everything and handle the =
exception
> afterward? This seems odd to me -- if an operation fails it shouldn't =
do anything.
>=20
> In PHP 7.1 I've rewritten print_r() to use an internal buffer, so we =
could handle
> this case completely gracefully. The same change could be implemented =
for
> var_dump(). With this approach we'd only print anything if no =
exception
> occurred.
>=20
How it sounds, there were two different ways to solve this in 7.0 and =
7.1? As 7.0 has limitations, IMHO it's fine to go by Hui's suggestion =
fatal+exception text. It could be also ok to leave the state as it was =
before 2d8ab515 in 7.0, so either way. But for 7.1, as it's possible to =
get rid of the fatal in favor of catchable exception, probably it'd be =
the right way to go. Is that what you suggest?

I had no chance to look into your print_r changes yet. Could it be =
possibly backported into 7.0, so both could go by same solution?

Thanks

Anatol