Newsgroups: php.cvs,php.internals Path: news.php.net Xref: news.php.net php.cvs:94969 php.internals:96333 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 99571 invoked from network); 12 Oct 2016 19:50:42 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 12 Oct 2016 19:50:42 -0000 Authentication-Results: pb1.pair.com header.from=anatol.php@belski.net; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=anatol.php@belski.net; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain belski.net from 85.214.73.107 cause and error) X-PHP-List-Original-Sender: anatol.php@belski.net X-Host-Fingerprint: 85.214.73.107 klapt.com Received: from [85.214.73.107] ([85.214.73.107:35206] helo=h1123647.serverkompetenz.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 33/67-41968-F049EF75 for ; Wed, 12 Oct 2016 15:50:40 -0400 Received: by h1123647.serverkompetenz.net (Postfix, from userid 1006) id AA9DA7849B8; Wed, 12 Oct 2016 21:50:36 +0200 (CEST) Received: from w530phpdev (p54A77722.dip0.t-ipconnect.de [84.167.119.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by h1123647.serverkompetenz.net (Postfix) with ESMTPSA id 630FD7849B2; Wed, 12 Oct 2016 21:50:34 +0200 (CEST) To: "'Bob Weinand'" , Cc: "'PHP Internals'" Date: Wed, 12 Oct 2016 21:50:30 +0200 Message-ID: <00c501d224c1$e589b120$b09d1360$@belski.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQGnIo/zEzmVvAoCdnrs4dy6SQ6SYqD7PfHA Content-Language: en-us Subject: RE: [PHP-CVS] com php-src: Add stdin command and -s command line parameter to phpdbg: run-tests.php sapi/phpdbg/phpdbg.c sapi/phpdbg/phpdbg_bp.c sapi/phpdbg/phpdbg_bp.h sapi/phpdbg/phpdbg_help.c sapi/phpdbg/phpdbg_list.c sapi/phpdbg/phpdbg_prompt.c sapi/p From: anatol.php@belski.net ("Anatol Belski") Hi Bob, > -----Original Message----- > From: Bob Weinand [mailto:bwoebi@php.net] > Sent: Wednesday, October 12, 2016 8:16 PM > To: php-cvs@lists.php.net > Subject: [PHP-CVS] com php-src: Add stdin command and -s command line > parameter to phpdbg: run-tests.php sapi/phpdbg/phpdbg.c > sapi/phpdbg/phpdbg_bp.c sapi/phpdbg/phpdbg_bp.h > sapi/phpdbg/phpdbg_help.c sapi/phpdbg/phpdbg_list.c > sapi/phpdbg/phpdbg_prompt.c sapi/phpdb >=20 > Commit: 5aae01104f88f98f42fd997d360757651f7cc919 > Author: Bob Weinand Wed, 12 Oct 2016 > 20:11:51 +0200 > Parents: 74b5662536ccdf9b7b02c495f02a27c64e27fff7 > Branches: PHP-7.0 >=20 > Link: http://git.php.net/?p=3Dphp- > src.git;a=3Dcommitdiff;h=3D5aae01104f88f98f42fd997d360757651f7cc919 >=20 > Log: > Add stdin command and -s command line parameter to phpdbg >=20 > This allows reading the initial script file from stdin instead of = being forced to put > the script into a file in order to run it with phpdbg. > Especially important for programmatic execution of phpdbg. >=20 > Also adding tests/include_once.phpt and = tests/set_exception_handler.phpt as I > seem to have forgotten to git add them sometime long ago... >=20 > Changed paths: > M run-tests.php > M sapi/phpdbg/phpdbg.c > M sapi/phpdbg/phpdbg_bp.c > M sapi/phpdbg/phpdbg_bp.h > M sapi/phpdbg/phpdbg_help.c > M sapi/phpdbg/phpdbg_list.c > M sapi/phpdbg/phpdbg_prompt.c > M sapi/phpdbg/phpdbg_prompt.h > A sapi/phpdbg/tests/include_once.phpt > A sapi/phpdbg/tests/set_exception_handler.phpt > A sapi/phpdbg/tests/stdin_001.phpt This patch contains at least one API breach -PHPDBG_API void phpdbg_set_breakpoint_file(const char *path, long = line_num) /* {{{ */ +PHPDBG_API void phpdbg_set_breakpoint_file(const char *path, size_t = path_len, long line_num) /* {{{ */ Please fix it for 7.0 at least. Also zend_strpprintf is not exported on Windows, so the build there is = broken. Thanks.