Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:96307
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain garfieldtech.com from 66.111.4.29 cause and error)
To: internals@lists.php.net
References: <CADVQu1QYkLGowNGVohfRvYWc=8N7tWfcjghOT0Zvx0_PuJSDYw@mail.gmail.com>
 <CAF+90c_otDn4V3AjsSPMbKg4mBcX5PT3B-Y97hEBqANThcksVg@mail.gmail.com>
 <CADVQu1SB4f2fivmjHZLLXPkEQaprrLe8rQoRm3Ln2QgtrC=xDA@mail.gmail.com>
Message-ID: <f64b7ae6-7cbf-4ccc-080c-b3850bd59289@garfieldtech.com>
Date: Mon, 10 Oct 2016 14:22:19 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <CADVQu1SB4f2fivmjHZLLXPkEQaprrLe8rQoRm3Ln2QgtrC=xDA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC] Bug #72811 - Replacing parse_url()
From: larry@garfieldtech.com (Larry Garfield)

On 10/07/2016 09:45 AM, David Walker wrote:
>> I think an important part of this interface is that the URL is constructed
>> using URL(url [, base]), where "base" is the base URL against which
>> relative URLs are resolved. This base URL is required for parsing
>> non-absolute URLs. To me this makes a lot of sense and I think it makes it
>> much clearer how "incomplete" URLs are being treated.
>>
> If we go the route of making URL it's own object, and expose an
> object-oriented interface, are we leading it to be more of a total URL
> builder, of sorts? Like:
>
> $url = new URL();
> $url->setScheme('http');
> $url->setHost('example.org');
> $url->setPath('/test.php');
> var_dump($url->build()); // outputs:  http://example.org/test.php
>
> OR, would it, at the end of the day be an object that takes a string, and
> you just call getter's on it that would be akin to the current flags you
> pass into parse_url()?
>
> On both accounts, if we're to go forward with the Object model of URL,
> would this want to be broken into it's own ext/url module, like how date
> exists?  Or retain it in ext/standard?
>
> Cheers
> --
> Dave

Be aware that a user-space definition for a URL object already exists as 
part of PSR-7:

http://www.php-fig.org/psr/psr-7/#3-5-psr-http-message-uriinterface

A core-provided mutable and incompatible object would be problematic.

What would be useful would be to have a C-level function (parse_url() or 
otherwise) that can generate a very well-known and standardized array 
structure (ie, better than parse_url()s now) that a UriInterface 
implementation could trivially wrap.  Basically, a way to simplify this 
existing code:

https://github.com/zendframework/zend-diactoros/blob/master/src/Uri.php#L435

And move the conditionals and filter*() sub-calls to C.  (Right now they 
play games with regexes and hope.)

--Larry Garfield