Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:96294
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain belski.net from 85.214.73.107 cause and error)
To: "'Davey Shafik'" <davey@php.net>,
	"'Nikita Popov'" <nikita.ppv@gmail.com>,
	"'Xinchen Hui'" <laruence@php.net>
Cc: "'Derick Rethans'" <derick@php.net>,
	"'PHP Developers Mailing List'" <internals@lists.php.net>
References: <alpine.DEB.2.20.1610071530340.3648@whisky.home.derickrethans.nl> <CAF+90c8F+jitXS4OGxy+b-BdhzdpGu3PvBhwB70eYLCFMqxohQ@mail.gmail.com> <CANaX5ndw-aTtAwepCNX90TzFdmX8dv3yMpjRpD83Be746Umiyg@mail.gmail.com>
In-Reply-To: <CANaX5ndw-aTtAwepCNX90TzFdmX8dv3yMpjRpD83Be746Umiyg@mail.gmail.com>
Date: Sat, 8 Oct 2016 20:06:27 +0200
Message-ID: <010701d2218e$b2e12d60$18a38820$@belski.net>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQItOLydTqT+dIGA3YBv5mmFOlapewMWylwtAqhC8kKfurBqgA==
Content-Language: en-us
Subject: RE: [PHP-DEV] Regression between RC1 and RC2?
From: anatol.php@belski.net ("Anatol Belski")

Hi,

> -----Original Message-----
> From: me@daveyshafik.com [mailto:me@daveyshafik.com] On Behalf Of =
Davey
> Shafik
> Sent: Friday, October 7, 2016 10:05 PM
> To: Nikita Popov <nikita.ppv@gmail.com>
> Cc: Derick Rethans <derick@php.net>; PHP Developers Mailing List
> <internals@lists.php.net>
> Subject: Re: [PHP-DEV] Regression between RC1 and RC2?
>=20
> Yes, we should not mask the exception. The behavior in 7.0/7.1.0RC1 is =
much
> better IMO.
>=20
> (As seen here: https://3v4l.org/EJpD4#v700)
>=20
> - Davey
>=20
> On Fri, Oct 7, 2016 at 12:52 PM, Nikita Popov <nikita.ppv@gmail.com> =
wrote:
>=20
> > On Fri, Oct 7, 2016 at 9:31 PM, Derick Rethans <derick@php.net> =
wrote:
> >
> > > Hi,
> > >
> > > I was looking at Xdebug for PHP 7.1, and I ran into the following
> > > inconsistency:
> > >
> > > https://3v4l.org/tHteN
> > >
> > > I first thought that Xdebug was messing up, but it seems like it's
> > > different behaviour in PHP itself. As I clearly return an array =
from
> > > __debugInfo, I don't think the new result is the correct one.
> > >
> > > cheers,
> > > Derick
> > >
> >
> > This is due to https://github.com/php/php-src/commit/
> > 2d8ab51576695630a7471ff829cc5ea10becdc0f, which landed in PHP-7.0 as
> well.
> > The problem is that __debugInfo currently is not able to handle
> > exceptions gracefully. I think we should revert this change for now =
as
> > it hides the fact that the underlying cause of the error is an =
exception.
> >
As far as I understand the bug #73067, it was about avoiding the fatal =
error, not about avoiding the exception. Please correct if I'm wrong. =
But given this, the fatal error still persists while the exception is =
removed. It looks like it's doing the exact reversed to what one would =
expect - no fatal error and the exception can be catched.

I see that it's not yet released in 7.0, so I would prefer to revert =
this in the release, at least. Hui, Nikita, do you think it's possible =
to improve this for 7.0 in a follow up? I would revert in 7.0.12 and =
there'll be room to fix it in the dev branch till 7.0.13. Otherwise I'd =
suggest to revert to the previous behavior in 7.0+ and do a fix in an =
appropriate higher branch.=20

Thanks

Anatol