Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:96286
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain brzuchalski.com designates 188.165.245.118 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAGa2bXYTWbEF437+PY-LgNq0m7PXj_PRNunpYnNa5aZ--Vaf4A@mail.gmail.com>
References: <CADVQu1QYkLGowNGVohfRvYWc=8N7tWfcjghOT0Zvx0_PuJSDYw@mail.gmail.com>
 <fa578fe5-6069-bc02-253e-ba849215a87a@gmx.de> <CADVQu1S5MDMqZRBovrMM94_=qyLvM5dkH_K4DwQJEx66mKruFQ@mail.gmail.com>
 <F3741613-1E6C-4978-8284-9EB505A46F2A@koalephant.com> <CADVQu1QLUs1PnbFo3=Hh3H3_1i_Hzso82So5WT74wz3jQ+8OLw@mail.gmail.com>
 <CADyq6sLWgoAPKTiqLLNVP4ECs15dQSvLKL12tanMfMVhDUYfvg@mail.gmail.com>
 <CABdc3WpA8JQHE=sOWsBiRB0LA=cT1CUUss+6gTKCSkGXyw8+YQ@mail.gmail.com>
 <CABdc3Wo9S9cNVebZfy4rPWy091p5EEwWjjRU11tjXiGkQwHjsA@mail.gmail.com> <CAGa2bXYTWbEF437+PY-LgNq0m7PXj_PRNunpYnNa5aZ--Vaf4A@mail.gmail.com>
Date: Fri, 7 Oct 2016 15:05:17 +0200
Message-ID: <CABdc3WpLuLq+=h_8E6YsG-VBGpDpqC3FRZBTXeZWUVMPhk6jSg@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: Marco Pivetta <ocramius@gmail.com>, David Walker <dave@mudsite.com>, 
	Stephen Reay <php-lists@koalephant.com>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=94eb2c125692dc1e42053e460fb0
Subject: Re: [PHP-DEV] [RFC] Bug #72811 - Replacing parse_url()
From: michal@brzuchalski.com (=?UTF-8?Q?Micha=C5=82_Brzuchalski?=)

--94eb2c125692dc1e42053e460fb0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

2016-10-07 12:55 GMT+02:00 Yasuo Ohgaki <yohgaki@ohgaki.net>:

> Hi Michal,
>
> On Fri, Oct 7, 2016 at 6:47 PM, Micha=C5=82 Brzuchalski
> <michal@brzuchalski.com> wrote:
> > 2016-10-07 11:21 GMT+02:00 Micha=C5=82 Brzuchalski <michal@brzuchalski.=
com>:
> >
> >> How about complete rewrite with OOP? It could be implemented using
> Objects
> >> like DateTime does.
> >> I've got working implementation in userland
> https://github.com/madkom/uri it
> >> maybe not be finished yet but supports parsing URI with IPv4, IPv6 and
> >> Hostnames.
> >> It was also going to parse query arguments from URI depending on how t=
o
> >> parse multiple arguments:
> >> * some languages parses `?arg1=3D1&arg1=3D2` as an array, PHP parses o=
nly
> last,
> >> * `?arg1[]=3D1&arg1=3D3` some parses adding element 3 to "arg1" array =
some
> >> replaces)
> >>
> >> This implementation also supports UriTemplates ("
> >> http://localhost/{module}/action") and UriReferences
> >> ("/some/reference?arg1=3D2#fragment").
> >>
> >
> > My proposed impl supports parsing and building, I can see there is
> possible
> > to move functionalities from few global functions into one OO  written
> > package.
>
> This is about internal C module implementation. re2c is one of the
> best way to write manageable BNF definition implementation. We use
> re2c many places already. Therefore, re2c implementation is the way to
> go. IMHO.
>
>
Yes I understand that implementation in C would be different, all I wanted
to point is nice OO implementation
with type hints and return types so there is no `mixed` return type value
used like in parse_url() and there
are always classes for each component of URL not only string and you don't
know what to do with it
Also avoiding mixed return type allows static code analyzers to detect
errors in code and all those OO benefits.


> Regards,
>
> --
> Yasuo Ohgaki
> yohgaki@ohgaki.net
>



--=20
regards / pozdrawiam,
--
Micha=C5=82 Brzuchalski
brzuchalski.com

--94eb2c125692dc1e42053e460fb0--