Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:96254
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.173 as permitted sender)
MIME-Version: 1.0
Reply-To: bishop@php.net
Sender: bishop.bettini@gmail.com
In-Reply-To: <12ac5812-8fd8-488c-aca4-0116b590201b@blastwave.org>
References: <090bbd8e-ebe9-0806-ca69-4ec28a56ce05@blastwave.org>
 <809f35f2-8018-5d13-377a-dd9c55e1392f@gmx.de> <12ac5812-8fd8-488c-aca4-0116b590201b@blastwave.org>
Date: Wed, 5 Oct 2016 12:59:11 -0400
Message-ID: <CAEYWF=4HQNA5CUQBuGrBfO_PPwn4wchiL-3FdeAUtJ-FX9YR3w@mail.gmail.com>
To: Dennis Clarke <dclarke@blastwave.org>
Cc: PHP internals <internals@lists.php.net>, Anatol Belski <anatol.php@belski.net>
Content-Type: multipart/alternative; boundary=f403045daa66690edc053e211ad4
Subject: Re: [PHP-DEV] Re: ext/fileinfo/libmagic/apprentice.c", line 2195:
 error: syntax error
From: bishop@php.net (Bishop Bettini)

--f403045daa66690edc053e211ad4
Content-Type: text/plain; charset=UTF-8

On Wed, Oct 5, 2016 at 12:51 PM, Dennis Clarke <dclarke@blastwave.org>
wrote:

>
> Not sure where the definition of "offsetof()" is located but something
>>> seems clearly not C compliant here.
>>>
>>> So this is using the Oracle Studio 12.5 compiler tools on a big old
>>> SPARC box running Solaris 10. Any input would be appreciated. The cflags
>>> were permissive and allowed for transition type elements as I note that
>>> C99 with strict compliance will fail horribly. The configure stage was
>>> reasonably clean also.
>>>
>>> In any case .. any input would be greatly appreciated.
>>>
>>
>> offsetof() is supposed to be declared in <stddef.h>[1].  Perhaps it
>> would need a typedef for your system?
>>
>
> hrmmm ... I don't think that is the issue here. Definately have that
> header and this is a POSIX compliant system for sure. In fact, from my
> $HOME/.profile :
>
> pretty sure I can carve that back to just items 1 to 6 above and use C99
> compiler /opt/developerstudio12.5/bin/c99 and cflags options -Xc to be
> really really strict.
>
> I think the error message is about the use of the "struct" keyword there.
>
> [1] <http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/
>> stddef.h.html>
>>
>
> yep .. know it well.
>
> I may just have to change the sources a wee bit and see what happens here.
> Maybe this is a GCC GNUism that snuck in.


Commit 2181ed2
<https://github.com/php/php-src/commit/2181ed2e2ab0c137d843e2ebea1d7d92e7d9b759#diff-8f841b91bdb2e623187010251ec474ba>
introduced the change, and I note that <stddef.h> is config guarded by
ifdef HAVE_STDDEF_H. So, perhaps check your configured values to see if
that header is detected properly.

--f403045daa66690edc053e211ad4--