Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:96242
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.49 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAObuZdvkZXqJN0TtuvT=9+ZhWCfMmDe8tw8q7ttZR1YEN5vHMQ@mail.gmail.com>
References: <004101d21e33$124edf90$36ec9eb0$@lool.fr> <3bc3c57695cdf6207724db47e6dbbbab@koti.fimnet.fi>
 <000401d21e4c$3e71d140$bb5573c0$@lool.fr> <CAObuZdvkZXqJN0TtuvT=9+ZhWCfMmDe8tw8q7ttZR1YEN5vHMQ@mail.gmail.com>
Date: Tue, 4 Oct 2016 13:33:12 -0600
Message-ID: <CAObuZdutR3zL1rkD+fXnRe76028GuRgZ4k=gA6dqTrvC-30tgg@mail.gmail.com>
To: Pascal KISSIAN <php-mailing-list@lool.fr>
Cc: =?UTF-8?Q?Lauri_Kentt=C3=A4?= <lauri.kentta@gmail.com>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7bb04fc29b4e72053e0f2189
Subject: Re: [PHP-DEV] Feature Request: inline pseudo-instruction
From: derokorian@gmail.com (Ryan Pallas)

--047d7bb04fc29b4e72053e0f2189
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Tue, Oct 4, 2016 at 1:31 PM, Ryan Pallas <derokorian@gmail.com> wrote:

>
>
> On Tue, Oct 4, 2016 at 8:33 AM, Pascal KISSIAN <php-mailing-list@lool.fr>
> wrote:
>
>> >-----Message d'origine-----
>> >De : Lauri Kentt=C3=A4 [mailto:lauri.kentta@gmail.com]
>> >Envoy=C3=A9 : mardi 4 octobre 2016 16:21
>> >=C3=80 : Pascal KISSIAN <php-mailing-list@lool.fr>
>> >Cc : internals@lists.php.net
>> >Objet : Re: [PHP-DEV] Feature Request: inline pseudo-instruction
>> >
>> >On 2016-10-04 14:33, Pascal KISSIAN wrote:
>> >> I have an application where a small file is included at multiple
>> >> places.
>> >>
>> >> The include is done about an average of 100.000 times .
>> >
>> >I'm just wondering if you have ever heard of functions? You really
>> should write a function, include it only once, and then simply call the
>> function instead of repeatedly >including the file. Calling a function i=
s a
>> lot faster than including a file.
>> >
>> >--
>> >Lauri Kentt=C3=A4
>>
>> Function is not appropriate when the "inlined code" has to share 20-30
>> local variables ...
>> Having a function with 30 args,  or having to build and access an array
>> is not very efficient nor natural...
>> Local variables include 6 nested "for loop" indices and local
>> variables/arrays needed for the computing.
>>
>
> As many have said this may be a sign of a need to refactor. however, to
> say that building an array and accessing it is not natural, consider that
> you can use compact / extract.
>
> function doLoops($vars) {
>     extract($vars);
>     // many for loops
>     return compact(implode(' ', array_keys($vars)));
> }
>
> // elsewhere set up a bunch of variables
> extract(doLoops(compact('list of variable names goes here')));
>
> Problem solved, now you are not including in a loop, but calling an
> already compiled function, without adding TONS of lines of code to build
> such an array. Its a short solution, to a problem that should probably le=
ad
> to a redesign of the functionality anyway.
>
>

Sorry that should be compact(array_keys($vars)), and same for the list
going in. Too many other languages lately!

>
>>
>>
>> --
>> PHP Internals - PHP Runtime Development Mailing List
>> To unsubscribe, visit: http://www.php.net/unsub.php
>>
>>
>

--047d7bb04fc29b4e72053e0f2189--