Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:96203 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 99944 invoked from network); 4 Oct 2016 01:55:35 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 4 Oct 2016 01:55:35 -0000 Authentication-Results: pb1.pair.com header.from=yohgaki@ohgaki.net; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=yohgaki@ohgaki.net; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain ohgaki.net designates 180.42.98.130 as permitted sender) X-PHP-List-Original-Sender: yohgaki@ohgaki.net X-Host-Fingerprint: 180.42.98.130 ns1.es-i.jp Received: from [180.42.98.130] ([180.42.98.130:42893] helo=es-i.jp) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 52/3A-06241-61C03F75 for ; Mon, 03 Oct 2016 21:55:35 -0400 Received: (qmail 104117 invoked by uid 89); 4 Oct 2016 01:55:30 -0000 Received: from unknown (HELO mail-qk0-f179.google.com) (yohgaki@ohgaki.net@209.85.220.179) by 0 with ESMTPA; 4 Oct 2016 01:55:30 -0000 Received: by mail-qk0-f179.google.com with SMTP id j129so172347760qkd.1 for ; Mon, 03 Oct 2016 18:55:29 -0700 (PDT) X-Gm-Message-State: AA6/9Rm1ZvUSbnnATsoH67BF/A7dBZ9h6IA9dSMaHLzT1zchc8aEw3g8BiIeyTjIxWERtuXHBrbDQzRRLArtow== X-Received: by 10.55.141.199 with SMTP id p190mr1212227qkd.185.1475546123958; Mon, 03 Oct 2016 18:55:23 -0700 (PDT) MIME-Version: 1.0 Received: by 10.140.84.168 with HTTP; Mon, 3 Oct 2016 18:54:43 -0700 (PDT) In-Reply-To: References: Date: Tue, 4 Oct 2016 10:54:43 +0900 X-Gmail-Original-Message-ID: Message-ID: To: Davey Shafik Cc: "internals@lists.php.net" Content-Type: text/plain; charset=UTF-8 Subject: Re: [PHP-DEV] [RFC][DISCUSSION] Improve uniqid() uniqueness From: yohgaki@ohgaki.net (Yasuo Ohgaki) Hi Davey, On Tue, Oct 4, 2016 at 4:59 AM, Davey Shafik wrote: > On Sunday, October 2, 2016, Yasuo Ohgaki wrote: >> >> Hi all, >> >> On Mon, Oct 3, 2016 at 3:56 AM, Yasuo Ohgaki wrote: >> > Besides improving "more entropy" the default and data, I prepared >> > fully compatible patch to simplify discussion. >> > >> > https://gist.github.com/anonymous/fb615df325d559fa806a265031a06ede >> > >> > I would like to apply this patch from PHP 7.0 branch, then discuss what >> > the default should be. >> > >> > Any comments? >> > If there is no objections, I'll apply this few days later. > > > Yasuo, > > This change should go through the standard RFC process and should be > targeted at 7.2+ (master) *only*. > > Please check with the RMs before merging functionality changes into release > branches. All functionality changes need consent and consensus. Bug fixes > (that don't change functionality or break BC) do not. > > I understand your desire to fix these things, especially the security > related type stuff, but as a group we have a responsibility to create > predictable, sane, and safe (as in, don't break stuff) migration paths when > we can. A history of doing this is WHY php is still going strong after so > long. > > Thanks, I agree fully. The only case this patch could break code is caused by broken PRNG in the system which is fatal anyway. i.e. If PRNG is broken, session module/randon_*() cannot produce secure session ID/values. We don't have to worry about changed behavior/BC. The main motivation is to simply this RFC discussion. I'll commit this patch master only. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net