Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:96191 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 20335 invoked from network); 2 Oct 2016 20:04:19 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 2 Oct 2016 20:04:19 -0000 Authentication-Results: pb1.pair.com header.from=yohgaki@ohgaki.net; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=yohgaki@ohgaki.net; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain ohgaki.net designates 180.42.98.130 as permitted sender) X-PHP-List-Original-Sender: yohgaki@ohgaki.net X-Host-Fingerprint: 180.42.98.130 ns1.es-i.jp Received: from [180.42.98.130] ([180.42.98.130:39687] helo=es-i.jp) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 5F/12-06241-14861F75 for ; Sun, 02 Oct 2016 16:04:18 -0400 Received: (qmail 16061 invoked by uid 89); 2 Oct 2016 20:04:13 -0000 Received: from unknown (HELO mail-qk0-f179.google.com) (yohgaki@ohgaki.net@209.85.220.179) by 0 with ESMTPA; 2 Oct 2016 20:04:13 -0000 Received: by mail-qk0-f179.google.com with SMTP id t7so148349665qkh.2 for ; Sun, 02 Oct 2016 13:04:12 -0700 (PDT) X-Gm-Message-State: AA6/9RnKF5k6GGOToLbaFk1O6l5eIozaxa13ob10KhFIeioeniRMLru55uCq0l7W+E1gJ1kULhQqL4hUnZBytQ== X-Received: by 10.55.121.67 with SMTP id u64mr18898745qkc.114.1475438646421; Sun, 02 Oct 2016 13:04:06 -0700 (PDT) MIME-Version: 1.0 Received: by 10.140.84.168 with HTTP; Sun, 2 Oct 2016 13:03:25 -0700 (PDT) In-Reply-To: References: Date: Mon, 3 Oct 2016 05:03:25 +0900 X-Gmail-Original-Message-ID: Message-ID: To: "internals@lists.php.net" Content-Type: text/plain; charset=UTF-8 Subject: Re: [RFC][DISCUSSION] Improve uniqid() uniqueness From: yohgaki@ohgaki.net (Yasuo Ohgaki) Hi all, On Mon, Oct 3, 2016 at 3:56 AM, Yasuo Ohgaki wrote: > Besides improving "more entropy" the default and data, I prepared > fully compatible patch to simplify discussion. > > https://gist.github.com/anonymous/fb615df325d559fa806a265031a06ede > > I would like to apply this patch from PHP 7.0 branch, then discuss what > the default should be. > > Any comments? > If there is no objections, I'll apply this few days later. Updated patch a little https://gist.github.com/yohgaki/cbe5431f9d072b57af2883a2b5745195 Exception should not be ignored, but added few lines for this. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net