Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:96133 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 77230 invoked from network); 25 Sep 2016 12:20:08 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 25 Sep 2016 12:20:08 -0000 Authentication-Results: pb1.pair.com header.from=danack@basereality.com; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=danack@basereality.com; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain basereality.com from 209.85.217.182 cause and error) X-PHP-List-Original-Sender: danack@basereality.com X-Host-Fingerprint: 209.85.217.182 mail-ua0-f182.google.com Received: from [209.85.217.182] ([209.85.217.182:34288] helo=mail-ua0-f182.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id E6/C6-11573-6F0C7E75 for ; Sun, 25 Sep 2016 08:20:06 -0400 Received: by mail-ua0-f182.google.com with SMTP id q42so83371962uaq.1 for ; Sun, 25 Sep 2016 05:20:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=basereality-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=eVVLG9Fgh4bvV+WczF230b43S4SwfI3TOHHDhLtHjOk=; b=GLevP1RvtvZne02kPU8zjURVgYib4h+2nYipcOIP7pTJ/3zA+2EKeLhRsrj6OfdMw8 3vswE48oqOZgwxt46lJsTlzIRP4EMPay8Dlzs57Ff5fD3kf6dSxBsRW7mz2kdI3vCAqt h6XWi57mRPNc1pmINGrMleHpRk+wWamkVQzZMeOPDHU4j9BeKPZVGI12IAiHiDd+oJ1r ylAy+mNDsUQpaKkX8rAEsEGthnCA+VGL4cVS7VKjFjLRrLW2B+UAGP9NmCcYkOoA+w9E +B1IRLOlfaKscQaAtPiOpOedWVc3RmGt/eyGkO/zqSeLd5XMWzycc5LeDE4Nyj2we710 UX+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=eVVLG9Fgh4bvV+WczF230b43S4SwfI3TOHHDhLtHjOk=; b=fMelhk45mF8MsmfboxUk4dK4Fo9cbij9J9oSOaKvPuE2xkoZWAQsy23IMoJJTxZcot /D3fxBB/8KFixu3sdkFkPmJnqmKzy/I+45nPApTzjtcC3Esdxj0Mm2LiP3wEqWydgzB4 /C8ob2ypP3q4IiDO0X0aVoGkdV+/4lMM6YwzenC1Bs8o/S/k5aEA62+9baInDe/hsvsz 5f5YB9Uu2MzE1ldBguuKe0mzhQO0xdsZ5Ei9CAFXyd1tGoZ4Urm4wrqZTzb/i2uwLYdn t5X8Avj1osHoZKZlTIsv9xJG1Qp8pmzyYLL+Byw3OWObFmRd7Uv28lZhWIugV27c26QQ f1Cw== X-Gm-Message-State: AE9vXwPGtOjlaNz8wpL3DFw5UKVJh+rDYTpqoK4LFHvHEMBdAtkEignFlrTn3O3TK33E+shzZkXg6y/PrTf1hg== X-Received: by 10.176.69.134 with SMTP id u6mr10731187uau.55.1474806003385; Sun, 25 Sep 2016 05:20:03 -0700 (PDT) MIME-Version: 1.0 Received: by 10.176.69.4 with HTTP; Sun, 25 Sep 2016 05:20:02 -0700 (PDT) X-Originating-IP: [2.99.239.160] In-Reply-To: References: Date: Sun, 25 Sep 2016 13:20:02 +0100 Message-ID: To: Pierre Joye Cc: PHP internals Content-Type: text/plain; charset=UTF-8 Subject: Re: [PHP-DEV] [VOTE] get_class() disallow null parameter From: danack@basereality.com (Dan Ackroyd) On 25 September 2016 at 06:29, Pierre Joye wrote: > I am pretty sure it is by design (for what I can remember) I do not believe that is correct. The commit message* says: "Restore PHP-5.2 behaviour when passing null inside object scope to get_class()" The commit does not restore the previous behaviour.** I'm pretty certain it was just a mistake. As Leigh noted, the behaviour is not clearly documented. In fact the manual also says: "If get_class() is called with anything other than an object, an E_WARNING level error is raised.". I'm pretty sure that null is not an object, so this RFC actually moves the behaviour closer to what the manual says. > I recommend the (future) RMs to veto this change. It is the role for Release Managers to prevent accidental changes happening, and to prevent changes being applied to releases when they haven't gone through the RFC process. Is is not the role of a Release Manager to prevent clear RFCs that have been through the RFC process from being applied. cheers Dan Ack * https://github.com/php/php-src/commit/dc74c5136e227bdc2ba1f2ce6f99170a7cf18cc8#diff-3ea93da7d1026a9f53948a5d14b1f7bd ** https://3v4l.org/f3G4N