Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:96131
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.41 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CA+kxMuQqKL7=+7NEAT8Nh6cWofJkNkQj7ujm7Ksi2yW_6cH0dQ@mail.gmail.com>
References: <CA+kxMuQqKL7=+7NEAT8Nh6cWofJkNkQj7ujm7Ksi2yW_6cH0dQ@mail.gmail.com>
Date: Sun, 25 Sep 2016 12:29:16 +0700
Message-ID: <CAEZPtU6o2eypGrQay-+eOtkU=V_03uJNQpaRr2MVwAGGgbz7-w@mail.gmail.com>
To: Dan Ackroyd <danack@basereality.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a114daaacf78b9c053d4e4af8
Subject: Re: [PHP-DEV] [VOTE] get_class() disallow null parameter
From: pierre.php@gmail.com (Pierre Joye)

--001a114daaacf78b9c053d4e4af8
Content-Type: text/plain; charset=UTF-8

Hi

On Sep 24, 2016 6:02 PM, "Dan Ackroyd" <danack@basereality.com> wrote:
>
> Hi,
>
> I'm going to put the 'get_class() disallow null parameter' RFC to a
> vote: https://wiki.php.net/rfc/get_class_disallow_null_parameter
>
> I realise that some people might prefer to have it target 8.0, rather
> than 7.2. While I appreciate that is a reasonable point of view, I
> personally believe that more people are hitting this as a bug than are
> using it deliberately.
>
> As the behaviour was altered in a point release, fixing it as a bug in
> a minor release seems reasonable to me.

We can agree that the behavior is debatable but I am pretty sure it is by
design (for what I can remember) and can make sense (can be considered ugly
but still).

Also this behavior is clearly documented:

http://th1.php.net/manual/en/function.get-class.php

"If object is omitted when inside a class, the name of that class is
returned."

I am opposed to break BC because we change our mind about how clean is this
behavior and I recommend the (future) RMs to veto this change.

Cheers
Pierre

--001a114daaacf78b9c053d4e4af8--