Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:96104 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 88549 invoked from network); 23 Sep 2016 01:16:18 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 23 Sep 2016 01:16:18 -0000 Authentication-Results: pb1.pair.com header.from=smalyshev@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=smalyshev@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.66 as permitted sender) X-PHP-List-Original-Sender: smalyshev@gmail.com X-Host-Fingerprint: 209.85.220.66 mail-pa0-f66.google.com Received: from [209.85.220.66] ([209.85.220.66:36035] helo=mail-pa0-f66.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 79/24-59356-16284E75 for ; Thu, 22 Sep 2016 21:16:17 -0400 Received: by mail-pa0-f66.google.com with SMTP id my20so4299716pab.3 for ; Thu, 22 Sep 2016 18:16:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=Xy08bifXrnhTaLevqEkrSd8SJD/3WeBYyVUvy4J3qpE=; b=yCYeuSDy5H35jX8QWlsMr8o/trLFEFXFYP/srFT4L6SuxrRoP3ZKaXxiYqSvrGGMwL UwX6lWmL4XPaJRvgaxk/oMLe5+DyTw8RPb9FtNY34BsoqfvWv63oOaNas1AVR4IJpYrS a2hXf6EPzLfxeJdeE4IRZy9HB5Zj4SWmq4XYEvhns1UECbbL26t1y2FY06IkrpL84oim dm+SjDtZmxUwr96Que5vg7LxO6IlEfjS6odmrd9peCnN8KQ2DV3QBOBMHJWLlZQej1NO 1Y0aM0DxVFnhqLpaF9UuzSJTruOktKgbE40CpJmpCJy8B8XPeY1/J3m5GrYr/rod8ayr hbNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=Xy08bifXrnhTaLevqEkrSd8SJD/3WeBYyVUvy4J3qpE=; b=F2WPKvdO4rXcuu5Vwk/xFq9K+X+IAB0qkiMcgvqUZQxaDtlWOuDRNQyx0xs3cZObRl 9swGPKnRRp8XCOuxEi9lbDPXfcUh1kS0MagVLt3enmz8sEFC1dMJCh2Zw7jspJ0u85fK X6qTLJbogJzSZk5GU/p7qAkvTFR3YU71af+VHCVAZyrfu39g81c9zoRW4MPMchieJsaz XQgtOLOmi4srQJ+n1sR9ZwQz0zTsMNxVsK1IOmqnHunfkk25MX/oMcnYjWJkxeooe3Rb RLuoNIcFPGT5k5YHoTpxVi4DGh6l6Z9ehEz5yAU4E1MHs382trKtOQmEMdLXJ/Aqbb2Y Dzsg== X-Gm-Message-State: AE9vXwOafdDQKNRbzGhl0lxiNkL+atCaPZXlMgxD7Vxgy5+RDCXmADsDVsABewleuJ8xxA== X-Received: by 10.66.131.74 with SMTP id ok10mr8119528pab.126.1474593374780; Thu, 22 Sep 2016 18:16:14 -0700 (PDT) Received: from [192.168.2.102] (108-233-206-104.lightspeed.sntcca.sbcglobal.net. [108.233.206.104]) by smtp.gmail.com with ESMTPSA id 21sm6646967pfo.80.2016.09.22.18.16.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Sep 2016 18:16:13 -0700 (PDT) To: Bob Weinand References: <40868951-8BDA-4860-884C-B8252C1839E3@gmail.com> <9ce33625-2737-9933-7dd1-4f7930bccfac@gmail.com> <9b0fcfa7-f4f8-bac3-5e1e-7e974f217a94@gmail.com> <5acaa405-8b76-ce00-1380-614f2f83b549@gmail.com> Cc: PHP internals list Message-ID: Date: Thu, 22 Sep 2016 18:16:12 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] HashDoS From: smalyshev@gmail.com (Stanislav Malyshev) Hi! > The patch is not only targeting JSON. He just used JSON as an example. > > Every function generating arrays with keys based on user-defined input > needs to be updated. That looks like a very good way to make a lot of mistakes, miss a lot of cases and end up playing whack-a-mole with covering all functions. Why not just patch zend_hash.c and be done with it? -- Stas Malyshev smalyshev@gmail.com