Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:96099
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.176 as permitted sender)
MIME-Version: 1.0
Sender: jakub.php@gmail.com
In-Reply-To: <CANUQDCjccQd_D_k1STdKd+2=OOkSOwjhL-GBrra5Qt1N0rQLsg@mail.gmail.com>
References: <CAKws9z2EWkNNhM7tOMh-_pQ3iLjVj7hbXTB1Hh3a19utPzj-9A@mail.gmail.com>
 <ffc669b5-8764-3879-0c5a-d047d75c9b45@gmail.com> <CAGa2bXYad=5CNKUR4GTR-uB8L1Gb-2CJk5Fiperz5D_CTL+rxw@mail.gmail.com>
 <9522ebc9-8d8b-045e-b701-02f1166063e6@gmail.com> <CAGa2bXYNZwKrT=Ei8r1DghGjqOGiMUVPEGY31wYK9Hpt+C9XMQ@mail.gmail.com>
 <CANUQDCjcnFdPyG133z6g0DdRLZjUG=+BRhcv4Es9Z+WeoU-Prg@mail.gmail.com>
 <CAFGtT7Zd3+iRuaJtwpML3hO6Kbdu7YtnNOE14zvA78E=QiNprg@mail.gmail.com>
 <40868951-8BDA-4860-884C-B8252C1839E3@gmail.com> <d2080444-9a17-b3db-89fa-c383155a5756@thefsb.org>
 <CAF+90c-uFg9A2f1SVYTNgjQuFX5PkenrtXd8kf37cYoG0EfgEw@mail.gmail.com>
 <edeb9734-a3d4-bd96-f57c-fa1687473e1b@gmail.com> <CAF+90c9HTpxtY8zeKoOfjdQXTkrVQSw8fb9Ws0-Qs_xmJtttZw@mail.gmail.com>
 <9ce33625-2737-9933-7dd1-4f7930bccfac@gmail.com> <CAEKnhAGg829gi7uEBimZqdd-cTvAn4a1HmjDfEoYeLO93_L2wQ@mail.gmail.com>
 <9b0fcfa7-f4f8-bac3-5e1e-7e974f217a94@gmail.com> <CAEKnhAF9XGsLqHU5H9aKDA=jWA5iD1ou8UwOX0=OpAC8tnzXdQ@mail.gmail.com>
 <5acaa405-8b76-ce00-1380-614f2f83b549@gmail.com> <CAEKnhAG50eG4RQSRjoZGFkSF_as1DZN5OrBWadyQG-chHDuVhw@mail.gmail.com>
 <CANUQDCjccQd_D_k1STdKd+2=OOkSOwjhL-GBrra5Qt1N0rQLsg@mail.gmail.com>
Date: Thu, 22 Sep 2016 20:23:16 +0100
Message-ID: <CAEKnhAG6prXHspzOMpOcddXwrJ2stR2+9qYhZHyTKOU+7KOO6A@mail.gmail.com>
To: Niklas Keller <me@kelunik.com>
Cc: Rowan Collins <rowan.collins@gmail.com>, PHP internals list <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a113cda4a05adca053d1d98da
Subject: Re: [PHP-DEV] HashDoS
From: bukka@php.net (Jakub Zelenka)

--001a113cda4a05adca053d1d98da
Content-Type: text/plain; charset=UTF-8

On Thu, Sep 22, 2016 at 8:13 PM, Niklas Keller <me@kelunik.com> wrote:

> 2016-09-22 20:10 GMT+02:00 Jakub Zelenka <bukka@php.net>:
>
>> On Thu, Sep 22, 2016 at 10:54 AM, Rowan Collins <rowan.collins@gmail.com>
>> wrote:
>>
>> > On 22/09/2016 10:48, Jakub Zelenka wrote:
>> >
>> >>
>> >> Nope the point of the Bob's patch is to use graceful handling with
>> >> exception that can be easily checked by the json parser for example!
>> See
>> >> https://github.com/php/php-src/pull/1706
>> >>
>> >
>> > Ah, I stand corrected, I hadn't seen that version referenced before.
>> >
>> > Am I right in thinking that the idea here is that if the context is
>> > exception-safe it can opt in to a more graceful handling mechanism? And
>> > that if not, it will go ahead and bail out as in Niki's patch?
>> >
>> >
>> Yeah it introduces new functions for updating hash which is used by json
>> for updating array and it's also in std object handler which is used when
>> updating json object. For some other bits like updating array, it will
>> stay
>> with fatal. The thing is that json parser can then easily check if there
>> was an exception and if so, it will set JSON_ERROR_DEPTH and clear it. It
>> seems much better though.
>
>
> But why JSON_ERROR_DEPTH and not a new constant?
>
>
Yeah I agree and I already suggested it in the PR an hour ago. ;)

https://github.com/php/php-src/pull/1706#discussion_r80102953

Cheers

Jakub

--001a113cda4a05adca053d1d98da--