Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:96081 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 86833 invoked from network); 21 Sep 2016 19:46:33 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 21 Sep 2016 19:46:33 -0000 Authentication-Results: pb1.pair.com header.from=nikita.ppv@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=nikita.ppv@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.176 as permitted sender) X-PHP-List-Original-Sender: nikita.ppv@gmail.com X-Host-Fingerprint: 209.85.161.176 mail-yw0-f176.google.com Received: from [209.85.161.176] ([209.85.161.176:33461] helo=mail-yw0-f176.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 5A/3E-04117-893E2E75 for ; Wed, 21 Sep 2016 15:46:32 -0400 Received: by mail-yw0-f176.google.com with SMTP id i129so72043220ywb.0 for ; Wed, 21 Sep 2016 12:46:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=+3l8kvaK6bso/KPmdwgaerq3im6pujWamTHEzLNZvDM=; b=XR7wQPHJHCdBCKjRiz7q0vhb9X6idr3CmJEo6nrsow/rmcB1dX2uhepqw7y2vbctm7 gU1kk8+LIbqkiJosAz/PP1Xo/DZPZ+wku5MpTTEakAQDgACIO2PLWe9S0MR4L9E5i62Y uEMYAUxP8vvnEPohbS0E00idwkjTLgUl/vcsZK0W8kdUyZ4pTStBp93cpjdBnB9HH0z3 Df+vxbuYQvXTaf3MfdlkKTMrWlFK/Oq2eu6SpLEVEGWfKPTpfm2/xKh3DghDNfzQDqZJ FzkZJmnsXqYYi9bMPFpiCUd6p2cNnTsD1Axx4rfAXTQbp2c5Iekx9XJoV3jo8qle8BpB F88w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=+3l8kvaK6bso/KPmdwgaerq3im6pujWamTHEzLNZvDM=; b=KVdYpJx3c8ZTtjhhGG5f7HIecqLIbgZKxkVOYzcgdha+Y7btNI9NWAyPUKJenx+i2I kEdgjG7wfRCBfKDu/LeafD2yBTJ0udLlhCk5si6v3RQWw4eGQvhpmtitVtdsuXOj8eqc +TMFTzFbQ3bu9nSxcnkGNiGPPsQYHI3oop0l3s4UkXvWDJfGmYcTmc1mi3ITvTdRRFAH 3qQQaBkgLZOELeNG6MaBgMYCIfofBKwLIkf6zAtqvDXIBnKvFRj86+tXB3HPwsA6qdvy dZSoW73BG8suu1q5Bg0AmRCKPVVYtFpQ13/A8YueRzLBtD2cs3m6IWjrgKnQZKsiJiyO TI2A== X-Gm-Message-State: AE9vXwO3kshy17oQFOO7VmQzjIPv4PMHJsg4j0dWZD+GUCyTRc4oGHlxZtDB8vs13TqOLgxH4SvSPd565da3zg== X-Received: by 10.13.239.6 with SMTP id y6mr36499775ywe.315.1474487190181; Wed, 21 Sep 2016 12:46:30 -0700 (PDT) MIME-Version: 1.0 Received: by 10.13.215.150 with HTTP; Wed, 21 Sep 2016 12:46:29 -0700 (PDT) In-Reply-To: References: Date: Wed, 21 Sep 2016 21:46:29 +0200 Message-ID: To: Nicolas Grekas Cc: Levi Morrison , "internals@lists.php.net" Content-Type: multipart/alternative; boundary=94eb2c034e0832c729053d09cdde Subject: Re: [PHP-DEV] Fix ReflectionType::__toString() BC break From: nikita.ppv@gmail.com (Nikita Popov) --94eb2c034e0832c729053d09cdde Content-Type: text/plain; charset=UTF-8 On Wed, Sep 21, 2016 at 8:47 PM, Nicolas Grekas wrote: > > > See https://github.com/php/php-src/pull/2136 > > > > On a technical note this is a potentially breaking change for C > > extensions. Since it is a currently a `zend_bool` its value is > > truthy/falsy; you are now applying specific meaning to values. > > > > Maybe someone else will have more insight into what might be affected > > realistically, but this is one reason this was not implemented this > > way to begin with. > > > > > Note that Nikita's proposal (i.e. stick to 7.0 behavior and ignore the > "nullable" bit) is free from this problem yet really fine also as far as BC > is concerned. > Here's a PR for the revert-to-7.0 + deprecate variant, in case we wish to adopt it: https://github.com/php/php-src/pull/2137 Nikita --94eb2c034e0832c729053d09cdde--