Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:96080 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 83811 invoked from network); 21 Sep 2016 19:11:17 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 21 Sep 2016 19:11:17 -0000 Authentication-Results: pb1.pair.com smtp.mail=jakub.php@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=jakub.php@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.181 as permitted sender) X-PHP-List-Original-Sender: jakub.php@gmail.com X-Host-Fingerprint: 209.85.161.181 mail-yw0-f181.google.com Received: from [209.85.161.181] ([209.85.161.181:36140] helo=mail-yw0-f181.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 94/BD-04117-45BD2E75 for ; Wed, 21 Sep 2016 15:11:17 -0400 Received: by mail-yw0-f181.google.com with SMTP id t67so70045195ywg.3 for ; Wed, 21 Sep 2016 12:11:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=kk5SGCJcQZKCiw2vn0dWaN5UihRYBNcOZNc2RCCE+0Q=; b=ogAEV2nT6Wwi8d/MltVj+G9/Kf/zOKHNGNbQ4/s6ROKb5zuVfMG0xkWjY1svVkn6HZ EluBGtcf6IoDaN/4Ru43yk04I7tVQN/DvnUnqwOJNbXISAvbPRLqjCNRMg9jnsglDczC yljQU9rfAcboMqbT0mnThjnmuqsy9mK9yFTg+LQTZHZJ6B4G0fUjaKskLlv65KoxyjRx LETea8+RiOWHRx+Zzqy6usyK6GBC2ZdJWOWkf6g3JeDv/aboJCvV4bpsOpgKU7WE/o5w CR88ixiM3PHzBujDRj5HarBfnzkBuNwvIBX0zSRWXJMy7nB9g/LVIZWDOW4rGjGSeXXo 4I+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=kk5SGCJcQZKCiw2vn0dWaN5UihRYBNcOZNc2RCCE+0Q=; b=JZ/zkKEFqElPETdIG6WJ7zEcIkugNDF3wV0wbXUb6kjKVkNy7/OCeNkeavZZJaaYzw 0Jt1Z8NSNbL9NBYUdEaHVkDNxqINobHd4K1k78GRHFSZ4LKihazoMv2PaGhKhXPKaPMU HMV825fFHuNwpvLRs33P0FaInTFmBtesYn5lqIMFICqZP6HZANMAaOxphSqjNmbvwHDO cN1oFnrhV63H2+U+XRarK7MIysS6Z7LcQ0wQtyhfmkMOgT2cAjGOjuy/+43vXXqpDMJ4 zHPScrOjSJK8gTBvyTc8vY9AQfG4vGLmY7ZoghTS7fxZuCP0efASi7p2AGSh1bDzqdE+ woBw== X-Gm-Message-State: AE9vXwOwosXo9qRNoWwFYQImtdxsUbg0F3qrDPE2i2PbWryrMCmAD4BoKG4K6LsaHVTwUBP+gM0/gw1PQW/QGw== X-Received: by 10.13.237.2 with SMTP id w2mr27804692ywe.339.1474485073906; Wed, 21 Sep 2016 12:11:13 -0700 (PDT) MIME-Version: 1.0 Sender: jakub.php@gmail.com Received: by 10.31.174.151 with HTTP; Wed, 21 Sep 2016 12:11:13 -0700 (PDT) In-Reply-To: References: Date: Wed, 21 Sep 2016 20:11:13 +0100 X-Google-Sender-Auth: 3VxzWbjDYmga3Ym-AsOLtRrtYuY Message-ID: To: Ryan Pallas Cc: Levi Morrison , Nicolas Grekas , internals Content-Type: multipart/alternative; boundary=94eb2c054bf60e9591053d094f2a Subject: Re: [PHP-DEV] Fix ReflectionType::__toString() BC break From: bukka@php.net (Jakub Zelenka) --94eb2c054bf60e9591053d094f2a Content-Type: text/plain; charset=UTF-8 On Wed, Sep 21, 2016 at 7:51 PM, Ryan Pallas wrote: > > > On Wed, Sep 21, 2016 at 12:44 PM, Jakub Zelenka wrote: > >> Hi, >> >> On Wed, Sep 21, 2016 at 7:07 PM, Levi Morrison wrote: >> >>> On Wed, Sep 21, 2016 at 11:13 AM, Nicolas Grekas >>> wrote: >>> >> To handle this in code written around current __toString seems pretty >>> > simple >>> > >>> > Yes it is, but that's not what we're talking about: >>> > BC is about having perfectly fine code working in e.g. 7.0 be still >>> working >>> > fine on 7.1 *without any change*. >>> > >>> > Right now, we have red test suites on php7.1rc2. >>> > This is the symptom of a BC break, by definition. >>> > And the issue is not the existing code we have, but the new one that is >>> > changing the behavior of the engine. >>> >>> This was understood when the decision was made. You seem to not be >>> understanding the bigger issue and instead focusing on the BC break >>> for a *single minor release, and a dot zero at that*. If we keep the >>> BC compat this method is redundant and useless forever. If we fix it >>> we break your code for *one single minor release, and a dot zero at >>> that*. Which is the bigger disruption? >>> >>> This is why the decision was made. It is better to have the useful >>> functionality from here on out than to preserve BC with a single minor >>> release, and a dot-zero at that. >>> >>> >> I'm just wondering, how is it possible that this got changed when the >> only RFC mentioning this change got rejected ( >> https://wiki.php.net/rfc/reflectiontypeimprovements )? I don't see any >> consensus in the later discussion so unless I missed something, which is >> quite possible, this change should not be there in the first place, right? >> > > The best I can find are these messages [1] where it specifically mentions > that toString should change even though this was rejected, and it had at > least some agreement at the time. > > [1] http://php-news.ctrl-f5.net/message/php.internals/94452 > >> >> Yeah my bad, missed that one! Thanks --94eb2c054bf60e9591053d094f2a--