Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:96079
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.48 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAEKnhAFSZbEoHrSq6DLqOrDNpShGq+Pe4debkOUFzRo+ZGJjhg@mail.gmail.com>
References: <CAOWwgpn1_ZHxQq9FpiwCYoqT3kVHH0k3LgO7E+eX5N2ybjDtrg@mail.gmail.com>
 <CAF+90c9XW7G-7CtKCWt+JOm5vE1XTnC92AkHvmBe9fohTOWeKA@mail.gmail.com>
 <CAOWwgpm6YL+kiwT=n8QdeKHVYg=KG7aCp=2Cv5qn0nRVNwR0bA@mail.gmail.com>
 <CAObuZduNr1oKRx0MKdGG=9XLADZF_tP4YORTk486kWa6CC_=Hg@mail.gmail.com>
 <CAOWwgpmjaYnsOcJ2_vACCpR95NNQk8C_PwyWtdwOA-s5FbfpSg@mail.gmail.com>
 <CAObuZdvjesE9=C8sFk_8wdbpUzu7g2CTUY6Js_mSitO6SbB2=Q@mail.gmail.com>
 <CAOWwgp=Cha7y0goSOkQPqCOEr1rwmG0+-6JGaiDZmqkhMfyrpQ@mail.gmail.com>
 <CAFMT4NoAEg+f_26d7Gt2RPTwUDRT65qRYMmhK0vBPiheFYBzGA@mail.gmail.com> <CAEKnhAFSZbEoHrSq6DLqOrDNpShGq+Pe4debkOUFzRo+ZGJjhg@mail.gmail.com>
Date: Wed, 21 Sep 2016 12:51:59 -0600
Message-ID: <CAObuZdtYWYbJ_oo7Whq+tT5dZhrDN=rNj-6cjryUJxMsasawVA@mail.gmail.com>
To: Jakub Zelenka <bukka@php.net>
Cc: Levi Morrison <levim@php.net>, Nicolas Grekas <nicolas.grekas@gmail.com>, 
	internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=94eb2c1943484edc24053d090a91
Subject: Re: [PHP-DEV] Fix ReflectionType::__toString() BC break
From: derokorian@gmail.com (Ryan Pallas)

--94eb2c1943484edc24053d090a91
Content-Type: text/plain; charset=UTF-8

On Wed, Sep 21, 2016 at 12:44 PM, Jakub Zelenka <bukka@php.net> wrote:

> Hi,
>
> On Wed, Sep 21, 2016 at 7:07 PM, Levi Morrison <levim@php.net> wrote:
>
>> On Wed, Sep 21, 2016 at 11:13 AM, Nicolas Grekas
>> <nicolas.grekas@gmail.com> wrote:
>> >> To handle this in code written around current __toString seems pretty
>> > simple
>> >
>> > Yes it is, but that's not what we're talking about:
>> > BC is about having perfectly fine code working in e.g. 7.0 be still
>> working
>> > fine on 7.1 *without any change*.
>> >
>> > Right now, we have red test suites on php7.1rc2.
>> > This is the symptom of a BC break, by definition.
>> > And the issue is not the existing code we have, but the new one that is
>> > changing the behavior of the engine.
>>
>> This was understood when the decision was made. You seem to not be
>> understanding the bigger issue and instead focusing on the BC break
>> for a *single minor release, and a dot zero at that*. If we keep the
>> BC compat this method is redundant and useless forever. If we fix it
>> we break your code for *one single minor release, and a dot zero at
>> that*. Which is the bigger disruption?
>>
>> This is why the decision was made. It is better to have the useful
>> functionality from here on out than to preserve BC with a single minor
>> release, and a dot-zero at that.
>>
>>
> I'm just wondering, how is it possible that this got changed when the only
> RFC mentioning this change got rejected ( https://wiki.php.net/rfc/
> reflectiontypeimprovements )? I don't see any consensus in the later
> discussion so unless I missed something, which is quite possible, this
> change should not be there in the first place, right?
>

The best I can find are these messages [1] where it specifically mentions
that toString should change even though this was rejected, and it had at
least some agreement at the time.

[1] http://php-news.ctrl-f5.net/message/php.internals/94452

>
> Cheers
>
> Jakub
>
>

--94eb2c1943484edc24053d090a91--