Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:96077
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.41 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAFMT4No7FAfXHTpQ_pWtkuzsc6qmuho=J3ZVo4MUns_uv_sijA@mail.gmail.com>
References: <CAOWwgpn1_ZHxQq9FpiwCYoqT3kVHH0k3LgO7E+eX5N2ybjDtrg@mail.gmail.com>
 <CAFMT4No7FAfXHTpQ_pWtkuzsc6qmuho=J3ZVo4MUns_uv_sijA@mail.gmail.com>
Date: Wed, 21 Sep 2016 20:47:18 +0200
Message-ID: <CAOWwgpmj2esX9R9x-x9SVG0s=7Oa49MaGTigkrv7Yw9+7u0tPg@mail.gmail.com>
To: Levi Morrison <levim@php.net>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11497a72b498a0053d08faab
Subject: Re: [PHP-DEV] Fix ReflectionType::__toString() BC break
From: nicolas.grekas@gmail.com (Nicolas Grekas)

--001a11497a72b498a0053d08faab
Content-Type: text/plain; charset=UTF-8

> > See https://github.com/php/php-src/pull/2136
>
> On a technical note this is a potentially breaking change for C
> extensions. Since it is a currently a `zend_bool` its value is
> truthy/falsy; you are now applying specific meaning to values.
>
> Maybe someone else will have more insight into what might be affected
> realistically, but this is one reason this was not implemented this
> way to begin with.
>


Note that Nikita's proposal (i.e. stick to 7.0 behavior and ignore the
"nullable" bit) is free from this problem yet really fine also as far as BC
is concerned.

--001a11497a72b498a0053d08faab--