Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:96051
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.53 as permitted sender)
MIME-Version: 1.0
References: <CAJMCqJnyx+MAGF0O674dMxXk3FH6hsnz4qUF1FNG_MUAFdKu_Q@mail.gmail.com>
 <CA+kxMuQanxj-azNpRnVk86HV6Uur7BG4nkjPk-yr5uoYn01Hdg@mail.gmail.com>
In-Reply-To: <CA+kxMuQanxj-azNpRnVk86HV6Uur7BG4nkjPk-yr5uoYn01Hdg@mail.gmail.com>
Date: Wed, 21 Sep 2016 12:49:18 +0000
Message-ID: <CAJMCqJmu8YuG0+k+59RxB1pO1A-0jakpK-V0dO12LaaNrN=yog@mail.gmail.com>
To: Dan Ackroyd <danack@basereality.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a113fbf04daf663053d03f98b
Subject: Re: [PHP-DEV] RFC: Strict comparisons
From: vpkaihla@gmail.com (Vesa Kaihlavirta)

--001a113fbf04daf663053d03f98b
Content-Type: text/plain; charset=UTF-8

On Tue, 20 Sep 2016 at 02:20 Dan Ackroyd <danack@basereality.com> wrote:

> Hi Vesa,
>
> On 19 September 2016 at 14:04, Vesa Kaihlavirta <vpkaihla@gmail.com>
> wrote:
> >
> > My idea is to add a strict_comparisons declaration that you can add at
> the
> > beginning of a file in the same way as strict_types.
> >
> > Please take a look and let me know if this would be worth a more official
> > RFC.
>
> I think it deserves an RFC.
>

Cool! I'll write some more unit test cases and start working on the RFC
text.

>
> One thing that might make people hesitant about this, is that it's
> likely that you would want to have the occasional weak comparison in a
> file.
>

> However that should mostly covered by just adding a cast where needed
> presumably? e.g. like:
>
> $foo = '5 apples';
>
> if ((int)$foo == 5) {
>     echo "eh, close enough";
> }
>

Yeah, that works. I added that as a test case.

What still worries me personally is ===. What do you think would be the
least incorrect way to handle === (and other identicality operations) when
strict_comparisons is in effect? I thought of the following options:

1) === works like ==, that is, makes type checks and throws exceptions if
the types don't match

2) === is not affected by strict_comparisons. It would then be *weaker*
than == when s_c is on (since it would just return false instead of
throwing). That would offer a sort of a convenient way out of the strictest
comparison mode, but might be confusing.

3) === is disabled/not allowed when s_c is on. Would lessen the risk of
confusion.


Thoughts?

--vk


>
> cheers
> Dan
>

--001a113fbf04daf663053d03f98b--