Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:96045
Return-Path: <nicolas.grekas@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 14605 invoked from network); 21 Sep 2016 08:55:24 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 21 Sep 2016 08:55:24 -0000
Authentication-Results: pb1.pair.com smtp.mail=nicolas.grekas@gmail.com; spf=pass; sender-id=pass
Authentication-Results: pb1.pair.com header.from=nicolas.grekas@gmail.com; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.48 as permitted sender)
X-PHP-List-Original-Sender: nicolas.grekas@gmail.com
X-Host-Fingerprint: 74.125.82.48 mail-wm0-f48.google.com  
Received: from [74.125.82.48] ([74.125.82.48:36224] helo=mail-wm0-f48.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id F7/F0-04117-BFA42E75 for <internals@lists.php.net>; Wed, 21 Sep 2016 04:55:24 -0400
Received: by mail-wm0-f48.google.com with SMTP id w84so180051030wmg.1
        for <internals@lists.php.net>; Wed, 21 Sep 2016 01:55:23 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:from:date:message-id:subject:to;
        bh=7+IEBDbKcDXmUP/1owRyPuzuQdoIwZV3mOpKLSLqdx0=;
        b=v7Z5v1Vmn2IFqlRnhK6wmb7iAsHM+pOEAgxVxk3/NWZfxzos2bHAEO2i7dJsI+Zkwb
         7h5u1ZcjjRjRygs2sgRDAcgvp5C+XzxElPERBaMBpk+/4K+ma4tX0f88CdCqWE+v6vZG
         JItju9iP/DtuvI7pgIgpSQbJdb0MgkPqc3mDuAO5/SlxM7BN289Y5tJFHafFW0Fm25Cr
         kZ3Dp7F3vNYTh6TFqQxF+fOSMFnX90VLJYBlxviKHGXY3cyIXgQpx1ukK0xuZLa1e8n8
         qx8sAN98cV3p+IQdYEcKVrklItj+v/hFq8ooZ5jpFUW80atAZX58Rz6Uv9/EcOM5OrvQ
         Lx/Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:mime-version:from:date:message-id:subject:to;
        bh=7+IEBDbKcDXmUP/1owRyPuzuQdoIwZV3mOpKLSLqdx0=;
        b=dFaFaFuuMIcV8oY6cXJCBOeItKOuFZRLnLn8VSkj5h9iKOQmcvB5ar57YBOSHmYVGl
         x5yS6kuLlB6Z/mBN9EpFyVMsGvFs48mQsOmpjnbb57eiZRgnoLvmEndFSjV1AVdex4jO
         U1SpXUyhKRlJF5WWW0bPVw9JRszXYbNrdpM+Wr19ZGTwmlAVsqbuhILdn6DiZQMQqi3k
         L7Vs2flunPv6LxplT1u7jY3rFhEM0wzcehxL6w/ZIPq0KwdyftOcprIJqfboVs+EWOr4
         fDHLMhqhNHeUai3DT/mk0TxtpdOgOrggOdsmjVMaA4pEZFCidzJIuhOyKG76XSYKH3gz
         s8+Q==
X-Gm-Message-State: AE9vXwO21bJGM6N9jnM28mApkPUCndebnDgOxA5RU09NZxApkiLLvWiOvwt5LAYwne4e2VCjAuNzVYhglHy08g==
X-Received: by 10.194.200.198 with SMTP id ju6mr31394080wjc.184.1474448120537;
 Wed, 21 Sep 2016 01:55:20 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.194.234.105 with HTTP; Wed, 21 Sep 2016 01:55:00 -0700 (PDT)
Date: Wed, 21 Sep 2016 10:55:00 +0200
Message-ID: <CAOWwgpn1_ZHxQq9FpiwCYoqT3kVHH0k3LgO7E+eX5N2ybjDtrg@mail.gmail.com>
To: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7b8750cc76e757053d00b437
Subject: Fix ReflectionType::__toString() BC break
From: nicolas.grekas@gmail.com (Nicolas Grekas)

--047d7b8750cc76e757053d00b437
Content-Type: text/plain; charset=UTF-8

Hello,

our turn to be hit by this 7.1 BC break in Symfony:
`ReflectionType::__toString()` now adds a `?` in front of type hints where
`null` is allowed by their default values.

But since `zend_bool` is really an `unsigned char`, we have plenty of room
to store and forward this semantic subtlety (nullable being set through
`?Foo $arg` vs `Foo $arg = null`) so that `ReflectionType::__toString()`
can be accurate again, thus BC.

See https://github.com/php/php-src/pull/2136

Thank for you consideration of this patch.

Cheers,
Nicolas

--047d7b8750cc76e757053d00b437--