Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:95966 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 80253 invoked from network); 13 Sep 2016 01:20:07 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 13 Sep 2016 01:20:07 -0000 Authentication-Results: pb1.pair.com smtp.mail=yohgaki@ohgaki.net; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=yohgaki@ohgaki.net; sender-id=pass Received-SPF: pass (pb1.pair.com: domain ohgaki.net designates 180.42.98.130 as permitted sender) X-PHP-List-Original-Sender: yohgaki@ohgaki.net X-Host-Fingerprint: 180.42.98.130 ns1.es-i.jp Received: from [180.42.98.130] ([180.42.98.130:38809] helo=es-i.jp) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 03/73-60695-44457D75 for ; Mon, 12 Sep 2016 21:20:05 -0400 Received: (qmail 85975 invoked by uid 89); 13 Sep 2016 01:20:01 -0000 Received: from unknown (HELO mail-qt0-f170.google.com) (yohgaki@ohgaki.net@209.85.216.170) by 0 with ESMTPA; 13 Sep 2016 01:20:01 -0000 Received: by mail-qt0-f170.google.com with SMTP id 38so82146738qte.1 for ; Mon, 12 Sep 2016 18:20:00 -0700 (PDT) X-Gm-Message-State: AE9vXwO4A9YvOKzacv9kt5KcuQzPwa5WZOYlY9qJPqJ9QesNXTZk0O1vQLYjKBM8E7v4FW/I5Whvlx0esKWNAg== X-Received: by 10.200.35.107 with SMTP id b40mr24392365qtb.38.1473729595214; Mon, 12 Sep 2016 18:19:55 -0700 (PDT) MIME-Version: 1.0 Received: by 10.140.84.168 with HTTP; Mon, 12 Sep 2016 18:19:14 -0700 (PDT) In-Reply-To: References: <878tuxenl4.fsf@lil.giraffy.jp> <87twdlcs2j.fsf@lil.giraffy.jp> <87h99lch13.fsf@lil.giraffy.jp> Date: Tue, 13 Sep 2016 10:19:14 +0900 X-Gmail-Original-Message-ID: Message-ID: To: Marco Pivetta Cc: Kazuo Oishi , "internals@lists.php.net" Content-Type: text/plain; charset=UTF-8 Subject: Re: [PHP-DEV] [RFC][DISCUSSION] Improve uniqid() uniqueness From: yohgaki@ohgaki.net (Yasuo Ohgaki) On Tue, Sep 13, 2016 at 10:14 AM, Yasuo Ohgaki wrote: >> I use `uniqid()` daily in my test suites, even new ones (not much else), and >> introducing the `.` everywhere will just cause issues. >> Changing string length may also break everything. > > It seems you have code that will be broken. > Could you share the code and what it does? BTW, my proposed code does not use "." at all. More entropy is [0-v]{10} from php_random_bytes(). Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net