Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:95965 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 78780 invoked from network); 13 Sep 2016 01:15:29 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 13 Sep 2016 01:15:29 -0000 Authentication-Results: pb1.pair.com smtp.mail=yohgaki@ohgaki.net; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=yohgaki@ohgaki.net; sender-id=pass Received-SPF: pass (pb1.pair.com: domain ohgaki.net designates 180.42.98.130 as permitted sender) X-PHP-List-Original-Sender: yohgaki@ohgaki.net X-Host-Fingerprint: 180.42.98.130 ns1.es-i.jp Received: from [180.42.98.130] ([180.42.98.130:38783] helo=es-i.jp) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 3B/13-60695-03357D75 for ; Mon, 12 Sep 2016 21:15:29 -0400 Received: (qmail 85685 invoked by uid 89); 13 Sep 2016 01:15:24 -0000 Received: from unknown (HELO mail-qt0-f172.google.com) (yohgaki@ohgaki.net@209.85.216.172) by 0 with ESMTPA; 13 Sep 2016 01:15:24 -0000 Received: by mail-qt0-f172.google.com with SMTP id 11so82099532qtc.0 for ; Mon, 12 Sep 2016 18:15:24 -0700 (PDT) X-Gm-Message-State: AE9vXwMk3QJzSYKmpGViZI6E7e9tnCtjOgOStXOGa9VWfnKljHZ0KEKGI7vowuXvvcSNqOJA7GS9mzTMzXi4Tg== X-Received: by 10.200.52.161 with SMTP id w30mr22472947qtb.31.1473729317981; Mon, 12 Sep 2016 18:15:17 -0700 (PDT) MIME-Version: 1.0 Received: by 10.140.84.168 with HTTP; Mon, 12 Sep 2016 18:14:37 -0700 (PDT) In-Reply-To: References: <878tuxenl4.fsf@lil.giraffy.jp> <87twdlcs2j.fsf@lil.giraffy.jp> <87h99lch13.fsf@lil.giraffy.jp> Date: Tue, 13 Sep 2016 10:14:37 +0900 X-Gmail-Original-Message-ID: Message-ID: To: Marco Pivetta Cc: Kazuo Oishi , "internals@lists.php.net" Content-Type: text/plain; charset=UTF-8 Subject: Re: [PHP-DEV] [RFC][DISCUSSION] Improve uniqid() uniqueness From: yohgaki@ohgaki.net (Yasuo Ohgaki) Hi Marco, On Mon, Sep 12, 2016 at 11:48 PM, Marco Pivetta wrote: > > Full ACK on what Kazuo said. > > I use `uniqid()` daily in my test suites, even new ones (not much else), and > introducing the `.` everywhere will just cause issues. > Changing string length may also break everything. It seems you have code that will be broken. Could you share the code and what it does? Thank you. -- Yasuo Ohgaki yohgaki@ohgaki.net