Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95948
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.44 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <87h99lch13.fsf@lil.giraffy.jp>
References: <CAGa2bXYg1kkoYGQNr8T2oTshuqrvweefYO+EdY41w1vwUM32iQ@mail.gmail.com>
 <878tuxenl4.fsf@lil.giraffy.jp> <CAGa2bXaTydTSZniX4dUA9h_FcNaymyqfDXQJO0zx1ZDfLmvWdg@mail.gmail.com>
 <87twdlcs2j.fsf@lil.giraffy.jp> <CAGa2bXaziNMtNAgsJgX-BCgLL9z2WkoSaP8aNVrAgwo9MJ4WEQ@mail.gmail.com>
 <87h99lch13.fsf@lil.giraffy.jp>
Date: Mon, 12 Sep 2016 16:48:50 +0200
Message-ID: <CADyq6sLDDGVByQ+HWWV66E7Apf5gr0ngFKVJen3-9=B_VrESqQ@mail.gmail.com>
To: Kazuo Oishi <kazuo@o-ishi.jp>
Cc: Yasuo Ohgaki <yohgaki@ohgaki.net>, "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1147ce1251a03b053c509967
Subject: Re: [PHP-DEV] [RFC][DISCUSSION] Improve uniqid() uniqueness
From: ocramius@gmail.com (Marco Pivetta)

--001a1147ce1251a03b053c509967
Content-Type: text/plain; charset=UTF-8

On Mon, Sep 12, 2016 at 4:46 PM, Kazuo Oishi <kazuo@o-ishi.jp> wrote:

> Hi,
>
> >> IMO, improving it (generate better semi-unique ID) is not important
> >> enoungh to introduce unnecessary BC break.  (Why returning string length
> >> is changed?)
> >
> > It cannot not produce unique ID by default as name "uniqid()" implies.
> > Reason is described in the RFC. Please read RFC because it's the
> > official proposal.
>
> I had read it, of course.  But I could not understand why you chose BC
> break way.
>
> Now, I understand your intention to change default value of
> "more_entropy" despite of BC break.  You do want to change the default
> behavior of uniqid.
>
> But I cannot agree.
>
> --
> Kazuo Oishi
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>
Full ACK on what Kazuo said.

I use `uniqid()` daily in my test suites, even new ones (not much else),
and introducing the `.` everywhere will just cause issues.
Changing string length may also break everything.

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/

--001a1147ce1251a03b053c509967--