Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95944
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.49 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAEZPtU51-NgbbEz6eiDq92Zn8HvGsEBwvZemPFFCB4FCSVvWHg@mail.gmail.com>
References: <CAGa2bXYg1kkoYGQNr8T2oTshuqrvweefYO+EdY41w1vwUM32iQ@mail.gmail.com>
 <878tuxenl4.fsf@lil.giraffy.jp> <CAGa2bXaTydTSZniX4dUA9h_FcNaymyqfDXQJO0zx1ZDfLmvWdg@mail.gmail.com>
 <87twdlcs2j.fsf@lil.giraffy.jp> <CAEZPtU7jjgUijqQTVzVgtN==b84BRHMbY8qLf8jg7pG5LuXoUQ@mail.gmail.com>
 <CAEZPtU51-NgbbEz6eiDq92Zn8HvGsEBwvZemPFFCB4FCSVvWHg@mail.gmail.com>
Date: Mon, 12 Sep 2016 19:48:25 +0700
Message-ID: <CAEZPtU7cTesdzad0cf7UcQXu1otjAKLN_9FLwNj+Znopvr4k6w@mail.gmail.com>
To: Kazuo Oishi <kazuo@o-ishi.jp>
Cc: PHP internals <internals@lists.php.net>, Yasuo Ohgaki <yohgaki@ohgaki.net>
Content-Type: multipart/alternative; boundary=001a113acde08eec76053c4ee97e
Subject: Re: [PHP-DEV] [RFC][DISCUSSION] Improve uniqid() uniqueness
From: pierre.php@gmail.com (Pierre Joye)

--001a113acde08eec76053c4ee97e
Content-Type: text/plain; charset=UTF-8

Hi,

On Sep 12, 2016 5:48 PM, "Kazuo Oishi" <kazuo@o-ishi.jp> wrote:
>
> Hi,
>
> > I know some code breaks, but it's not many. It's not fatal BC also.
> >
> > IMHO, uniqid() should try to generate uniqid() possible. uniqid() does
produce
> > non unique ID because it is system time based. This change mitigates
impact of
> > misuse also which is common in both open and close codes.
> >
> > Which is important?
> >  - Fix known issues and generate unique ID (as much as possible)
> >  - Let it generate non unique ID and ignore for some code may complain.
>
> IMO, improving it (generate better semi-unique ID) is not important
> enoungh to introduce unnecessary BC break.  (Why returning string length
> is changed?)

I fully agree.

> If good unique ID generator is needed in core, please create new
> function with another name like "unique_id".

I would prefer to document the limitations and point to uuid or the Peng
instead of trying to fix something that was not designed to achieve that
(or was   but at a time where the results were acceptable).

> --
> Kazuo Oishi
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>

--001a113acde08eec76053c4ee97e--