Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95935
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain giraffy.jp designates 49.212.134.110 as permitted sender)
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: "internals\@lists.php.net" <internals@lists.php.net>
In-Reply-To: <CAGa2bXaTydTSZniX4dUA9h_FcNaymyqfDXQJO0zx1ZDfLmvWdg@mail.gmail.com>
	(Yasuo Ohgaki's message of "Mon, 12 Sep 2016 15:56:28 +0900")
References: <CAGa2bXYg1kkoYGQNr8T2oTshuqrvweefYO+EdY41w1vwUM32iQ@mail.gmail.com>
	<878tuxenl4.fsf@lil.giraffy.jp>
	<CAGa2bXaTydTSZniX4dUA9h_FcNaymyqfDXQJO0zx1ZDfLmvWdg@mail.gmail.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
Date: Mon, 12 Sep 2016 19:48:04 +0900
Message-ID: <87twdlcs2j.fsf@lil.giraffy.jp>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [PHP-DEV] [RFC][DISCUSSION] Improve uniqid() uniqueness
From: kazuo@o-ishi.jp (Kazuo Oishi)

Hi,

> I know some code breaks, but it's not many. It's not fatal BC also.
>
> IMHO, uniqid() should try to generate uniqid() possible. uniqid() does produce
> non unique ID because it is system time based. This change mitigates impact of
> misuse also which is common in both open and close codes.
>
> Which is important?
>  - Fix known issues and generate unique ID (as much as possible)
>  - Let it generate non unique ID and ignore for some code may complain.

IMO, improving it (generate better semi-unique ID) is not important
enoungh to introduce unnecessary BC break.  (Why returning string length
is changed?)

If good unique ID generator is needed in core, please create new
function with another name like "unique_id".

-- 
Kazuo Oishi