Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95923
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain giraffy.jp designates 49.212.134.110 as permitted sender)
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: "internals\@lists.php.net" <internals@lists.php.net>
In-Reply-To: <CAGa2bXYg1kkoYGQNr8T2oTshuqrvweefYO+EdY41w1vwUM32iQ@mail.gmail.com>
	(Yasuo Ohgaki's message of "Mon, 12 Sep 2016 11:54:40 +0900")
References: <CAGa2bXYg1kkoYGQNr8T2oTshuqrvweefYO+EdY41w1vwUM32iQ@mail.gmail.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
Date: Mon, 12 Sep 2016 13:41:59 +0900
Message-ID: <878tuxenl4.fsf@lil.giraffy.jp>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [PHP-DEV] [RFC][DISCUSSION] Improve uniqid() uniqueness
From: kazuo@o-ishi.jp (Kazuo Oishi)

Hi,

> This is RFC for improving uniqid() uniqueness.
> https://wiki.php.net/rfc/uniqid
>
> PR
> https://github.com/php/php-src/pull/2123
>
> If there is anything left to discuss, please comment.

I think uniqid() should not be changed in BC break way, it should be
left as is.

You said,

>> Almost all uniqid() usages do not care about return value chars nor
>> length. Therefore, BC will be minimum.
>>
>> https://searchcode.com/?q=uniqid&loc=0&loc2=10000&lan=24

but you may be underestimating.

I found that some code saved output of uniqid() without more_entropy to
DB, in the search results.  Output length change may cause problem in
such case.  And you are not supposed to forget that most of php codes
are not open source and not opened to the public.

In addition, you shoud hear "I expect the numbers to grow" about output
of uniqid(), as reply to you.

-- 
Kazuo Oishi