Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:95920 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 59609 invoked from network); 12 Sep 2016 02:31:31 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 12 Sep 2016 02:31:31 -0000 Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.218.52 as permitted sender) X-PHP-List-Original-Sender: pierre.php@gmail.com X-Host-Fingerprint: 209.85.218.52 mail-oi0-f52.google.com Received: from [209.85.218.52] ([209.85.218.52:35391] helo=mail-oi0-f52.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 31/10-58405-38316D75 for ; Sun, 11 Sep 2016 22:31:31 -0400 Received: by mail-oi0-f52.google.com with SMTP id d191so65950757oih.2 for ; Sun, 11 Sep 2016 19:31:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=dDeb4WrsuDiIeO70ZzIzjiaQaphHIs+d0wrKPTeDxQg=; b=qsi34kyzS157DY/vfaF6AT7KxKPp5465FTp713NQhJGibPpx+ZNXV2wsas4u/nzTQU QT72uqxuCYIV8GawNhWBSBM6UEq3XhKLLPxWXiOjh5U8n2nubYBmeplg3ZZmTe8sGUg5 6xFvkYeohBiq/B5IhnY0zHZF2hFXhFQf3vOIb2jU2QQLr0Qbxtg/LrUXziXGTCqe87Ph ol+/11RXR7xhQ0537ebH5a1TYrqeJv89ZDtm1sUXz0f7JUB/vupfuHOCyQWN6X7r+uL1 GV4wMCymY7kcQoMAXKpbD6qnebSesaLHSW0v9YMe5HmkCZs/iPTyUZI7pfxJhZfAAUM5 DQww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=dDeb4WrsuDiIeO70ZzIzjiaQaphHIs+d0wrKPTeDxQg=; b=ODvPTSCo/zdhlSDEXAP2Wp1QnFTg/h67APbtxR/G9yGsmXUaZicFIoe5sGq2kZfZJX X9z8y0AzzK/YtA0D7xlV5utDUsqv9fYm1zHsJwY/kA8Juk3ck+fXFKcfyo397De1ykV0 yr3hw4sIxhmG5e7k3XXMsie2siKSjowNtOEVMW9xKCsxIsILab4fSXLV7QoE164SHdwA mnAEZJl8zcEZeo6ArtrlCCZyq3XHdTpOVPF90RxEhA6Dt6Cn2U2L8AbE7NL7kRRXCDR1 QTVoj4RWV7F3Se6UZQ5qdKEKp/7z6JjLXWy2XekLqXYPJ15gW5ba8f87lyOkEb+3Y0Sp GPkw== X-Gm-Message-State: AE9vXwMv7YFcOzQ2H7uayR/U3N4cYO4CGZ3i5HG4kM4msR4TgHXVgWSTVuiJU8HOl1TgQ6olZIJQzLJ19HBZ2A== X-Received: by 10.157.45.138 with SMTP id g10mr17853404otb.88.1473647488236; Sun, 11 Sep 2016 19:31:28 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.51.85 with HTTP; Sun, 11 Sep 2016 19:31:26 -0700 (PDT) Received: by 10.202.51.85 with HTTP; Sun, 11 Sep 2016 19:31:26 -0700 (PDT) In-Reply-To: References: Date: Mon, 12 Sep 2016 09:31:26 +0700 Message-ID: To: Andrea Faulds Cc: PHP internals Content-Type: multipart/alternative; boundary=94eb2c04f0cc0f8392053c464bc4 Subject: Re: [PHP-DEV] Follow up to "The death of `#ifndef FAST_ZPP`?" From: pierre.php@gmail.com (Pierre Joye) --94eb2c04f0cc0f8392053c464bc4 Content-Type: text/plain; charset=UTF-8 Hi Andrea, On Sep 12, 2016 4:57 AM, "Andrea Faulds" wrote: > > Hi everyone, > > Andrea Faulds wrote: >> >> I finally wrote a patch to get rid of it: >> >> https://github.com/php/php-src/pull/2118 >> >> Perhaps this will go somewhere. :) > > > This has now been merged into PHP-7.0 and up: > > https://github.com/php/php-src/commit/d690014bf35507ccb7a1150a27504d2f87848842 > > Additionally, extra zpp fallback code only found in master has been removed here: > > https://github.com/php/php-src/commit/3cc90901010f016923e9ca6a4ae15ba08bc18169 > > Now there is no fallback zpp code around, and Fast ZPP is always enabled. > > The FAST_ZPP macro itself remains for compatibility with outside extensions, but it doesn't do anything within php-src. > > If you're writing a function that needs parameter parsing and which targets only PHP 7.0+, you now don't need to (and shouldn't) include zpp fallback code if you're using Fast ZPP. > > Thanks! Thanks you :) Please add this note to UPGRADING.INTERNALS as well : Cheers Pierre --94eb2c04f0cc0f8392053c464bc4--