Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:95919 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 50022 invoked from network); 11 Sep 2016 21:57:54 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 11 Sep 2016 21:57:54 -0000 X-Host-Fingerprint: 90.210.122.243 unknown Received: from [90.210.122.243] ([90.210.122.243:29929] helo=localhost.localdomain) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id E6/5C-46544-063D5D75 for ; Sun, 11 Sep 2016 17:57:53 -0400 Message-ID: To: internals@lists.php.net References: Date: Sun, 11 Sep 2016 22:57:48 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:43.0) Gecko/20100101 Firefox/43.0 SeaMonkey/2.40 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Posted-By: 90.210.122.243 Subject: Follow up to "The death of `#ifndef FAST_ZPP`?" From: ajf@ajf.me (Andrea Faulds) Hi everyone, Andrea Faulds wrote: > I finally wrote a patch to get rid of it: > > https://github.com/php/php-src/pull/2118 > > Perhaps this will go somewhere. :) This has now been merged into PHP-7.0 and up: https://github.com/php/php-src/commit/d690014bf35507ccb7a1150a27504d2f87848842 Additionally, extra zpp fallback code only found in master has been removed here: https://github.com/php/php-src/commit/3cc90901010f016923e9ca6a4ae15ba08bc18169 Now there is no fallback zpp code around, and Fast ZPP is always enabled. The FAST_ZPP macro itself remains for compatibility with outside extensions, but it doesn't do anything within php-src. If you're writing a function that needs parameter parsing and which targets only PHP 7.0+, you now don't need to (and shouldn't) include zpp fallback code if you're using Fast ZPP. Thanks! -- Andrea Faulds https://ajf.me/