Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95904
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.218.51 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CADyq6sJjGGS30oVqjFvhYS96UpPwv4uhZBCTrZGdLm5K_HNbhQ@mail.gmail.com>
References: <CAA69SC5w-0KAGcX_akmhtFJL=mte+3ZrShKPtnWgcML+z-HhKw@mail.gmail.com>
 <CABdc3WqGZ9GML-jb31FPudkML9eojpJ-Ap3kPsyd_5d8_fnwAQ@mail.gmail.com>
 <642a6e78-90ea-cbf0-ec1c-376c24e568c5@fleshgrinder.com> <CABdc3WqGFyM23CNA0eaMAyCn8L0=TaUf3xSoBOsFY_Gz4Z5uGA@mail.gmail.com>
 <CABdc3WqdTOid2BTGfpyVmNAca_9roxxx6AaQhKUPSYownO8MsA@mail.gmail.com>
 <0800a5ca-3d14-c541-1a1a-2574ec802b8c@fleshgrinder.com> <83fa661e-2d3d-6548-a506-fb969be31c0e@garfieldtech.com>
 <CAA69SC4=BXomSjmwm_6AEQGWqQqDC9scCVfv0aDH_rXMdZwt2A@mail.gmail.com>
 <c179bdb7-8665-9998-6f4f-99bbbfd19131@fleshgrinder.com> <CABdc3Wq_zfifnU=Y7TY8AXakBNO_KyDxaMhk0+Kubao_wGXaTg@mail.gmail.com>
 <56acc1d9-f424-a460-59be-3a9a1a74b198@fleshgrinder.com> <e06a39a8-305a-2de1-a8a7-e249d8179b09@gmx.de>
 <CAA69SC7wzKc2djTX267gaVpKd5-28H_GwAq2UBpzpRrqUfjpKQ@mail.gmail.com>
 <CAA69SC4QHSPpTo69X8siUv9gNmWdkgiBoiFE9Dsv_7n+Hnkpmw@mail.gmail.com>
 <b5f4cdb7-ab12-e508-5e1d-03d55db4eca0@gmx.de> <95832b08-ee80-18c1-a3da-202eed51903e@fleshgrinder.com>
 <CAA69SC69gRyyk5VcacHiD6vO+PrmHi-dUskOriV9q6o62KpkEg@mail.gmail.com>
 <CANUQDCg23Tu5f2vy_1V0yjYRk7KmfYGtTDbX49mA-aTRt7ZK9w@mail.gmail.com> <CADyq6sJjGGS30oVqjFvhYS96UpPwv4uhZBCTrZGdLm5K_HNbhQ@mail.gmail.com>
Date: Sat, 10 Sep 2016 22:00:14 +0200
Message-ID: <CAA69SC4eOJ5=vviAzdZ+EbvRojFS-ZG7n6b-1Pk36g_fQzJcyw@mail.gmail.com>
To: Marco Pivetta <ocramius@gmail.com>
Cc: Larry Garfield <larry@garfieldtech.com>, Niklas Keller <me@kelunik.com>, 
	PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11494724290009053c2cb6d6
Subject: Re: [PHP-DEV] RFC - Immutable classes
From: marijic.silvio@gmail.com (=?UTF-8?Q?Silvio_Mariji=C4=87?=)

--001a11494724290009053c2cb6d6
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

I agree. Will add this feature to RFC also

Cheers
On Sep 10, 2016 8:02 PM, "Marco Pivetta" <ocramius@gmail.com> wrote:

> On Sat, Sep 10, 2016 at 7:49 PM, Niklas Keller <me@kelunik.com> wrote:
>
>> 2016-09-10 19:41 GMT+02:00 Silvio Mariji=C4=87 <marijic.silvio@gmail.com=
>:
>>
>> > @Fleshgrinder,
>> >
>> > While I'm not sure at the moment about CoW, I can agree that we should
>> add
>> > immutable keyword as a interface modifier to make sure all classes
>> > implementing must be immutable.
>>
>>
>> As interfaces can't have member variables, that doesn't make sense to me=
.
>>
>
> It still makes sense from a consumer perspective, so having the
> restriction in the contract is quite good.
>
> If you accept a `Number`, you expect to be able to serialize/de-serialize
> it, and you expect it to be "locked", immutable.
> If you let an implementation of `Number` to have mutable state in, then
> you break all the code that relies on `Number`.
> Note that it is still possible to break this though, so maybe we'd need
> some other modifiers about behavior too (pure function modifier?)
>
> immutable interface Number
> {
>     public function toFloat() : float;
> }
> immutable class RandomNumber implements Number
> {
>     public function toFloat() : float { return (float) random_int(1,
> 100000); /* yo, look at my global mutable hidden state! */ }
> }
>
> Requiring immutable values in consumers will likely improve code
> quality/safety and reduce dangerous assumptions, and it will probably als=
o
> allow for optimizations in the engine later on.
>
> Marco Pivetta
>
> http://twitter.com/Ocramius
>
> http://ocramius.github.com/
>
>

--001a11494724290009053c2cb6d6--