Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95890
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.218.44 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CANUQDChAkm7uvsX4GWLcFSThv7h=LUm4JrfdgEBJ9AzLzsnw0A@mail.gmail.com>
References: <CAGa2bXaM8q0mwhkz+XL6jbBaVLHDZ_-Jfj0aOPUq+te=fV=wow@mail.gmail.com>
 <CANUQDCgcmLozTs4xcTTXfqd_UZC9oEKubmr_iZfYLwBcg3sxfQ@mail.gmail.com>
 <CAGa2bXb-ZD9ea+o4xqqsFtQJw7iM0Pzq1XTgof_2UPSTaY2PSg@mail.gmail.com>
 <CAL0xaBE-HzFz+rbzBJ_bEM1fuCKjcQ1K5yAokQra+CFMP_8x3w@mail.gmail.com>
 <CANUQDCgFzzCNCihP7DnsZRv8k7WkOT7htB_tKpoSp1wqpizmCQ@mail.gmail.com>
 <CAL0xaBGf=iTNTU51p2XniX84REykwg-D8v0VWxkSKAvnYdmZCA@mail.gmail.com>
 <CAGa2bXas59za=AunyQLqnF6jJkrGfPcS2q4jhq7CO1J0Jt8Qhg@mail.gmail.com> <CANUQDChAkm7uvsX4GWLcFSThv7h=LUm4JrfdgEBJ9AzLzsnw0A@mail.gmail.com>
Date: Sat, 10 Sep 2016 10:35:43 +0700
Message-ID: <CAEZPtU4JiYfZbW-=nnguwQcaaNe+sbchpDxNzrvejTBNXQJ1ew@mail.gmail.com>
To: Niklas Keller <me@kelunik.com>
Cc: PHP internals <internals@lists.php.net>, Yasuo Ohgaki <yohgaki@ohgaki.net>, 
	Arvids Godjuks <arvids.godjuks@gmail.com>
Content-Type: multipart/alternative; boundary=001a1144951646b3a5053c1ef5d5
Subject: Re: [PHP-DEV] [RFC] Make uniqid() more unique
From: pierre.php@gmail.com (Pierre Joye)

--001a1144951646b3a5053c1ef5d5
Content-Type: text/plain; charset=UTF-8

Hi,

On Sep 9, 2016 7:50 PM, "Niklas Keller" <me@kelunik.com> wrote:
>
> 2016-09-09 13:48 GMT+02:00 Yasuo Ohgaki <yohgaki@ohgaki.net>:
>
> > Hi all,
> >
> > On Fri, Sep 9, 2016 at 8:18 PM, Arvids Godjuks <arvids.godjuks@gmail.com
>
> > wrote:
> > >
> > > Hm, without "true" you get 13 chars, with "true" - 20+.
> >
> > Sorry. It's
> >
> > $ php -r 'var_dump(uniqid(), uniqid("", true));'
> > string(13) "57d29c20c04c3"
> > string(23) "57d29c20c04c50.55225401"
> >
> > I misread sprintf format.
> >
> > Anyway, we may use extra 10 chars to make it more random if it should
> > keep compatibility.
>
>
> That still breaks BC as the value is now longer than before.
>
>
> > It seems uniqid() is popular for test scripts, so
> > it would be preferred keeping it.
>
>
> Nobody said it should be removed now. Maybe in the future. But you might
as
> well just use bin2hex(random_bytes(16)).

Or uuid. This why this standard exists. I would recommend to move to that
instead of trying to reinvent the wheel.

https://github.com/ramsey/uuid is pretty good.

Cheers
Pierre

--001a1144951646b3a5053c1ef5d5--