Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95884
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.218.44 as permitted sender)
MIME-Version: 1.0
Sender: kalle.php@gmail.com
In-Reply-To: <CANaX5neS6uEofkOGc-KjfebPTs9yTaD+DuOzhP_3hfQFvZG7nA@mail.gmail.com>
References: <CANaX5neS6uEofkOGc-KjfebPTs9yTaD+DuOzhP_3hfQFvZG7nA@mail.gmail.com>
Date: Sat, 10 Sep 2016 02:42:03 +0200
Message-ID: <CAJW__o3iaMsvvKusGZh2jynk-Y-tXxFQ2JXjt1LpmtdFJ=ydTQ@mail.gmail.com>
To: Davey Shafik <davey@php.net>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] [RFC] [VOTE] Add PHP Engine Constant Identifier
From: kalle@php.net (Kalle Sommer Nielsen)

Hi Davey

2016-09-10 1:49 GMT+02:00 Davey Shafik <davey@php.net>:
> Hi all,
>
> As noted last week, I'm now opening up the vote for adding a PHP Engine
> Identifier constant to PHP 7.2+ (and more importantly, to the language
> spec). Additionally, there is a second vote to add corresponding
> PHP_ENGINE_(*_)VERSION(_ID) constants.

While I understand the reasoning behind it, I do not think that it is
our problem to solve, whether we do if(defined('HHVM_VERSION')) or
if(PHP_ENGINE == 'hhvm') seems irrelevant to me. If code are not
compliant with the spec, then it should be that implementors
responsibility to make sure that it is resolved imho.

I do not have anything against HHVM or alternative implementations of
PHP, it rocks, but I think we need to look in other directions, as it
shouldn't be needed at all to check for what runs your PHP, it should
_just_ work. For syntax incompatibility, then we can't even filter out
other implementations with a constant thats executed at runtime
either, not that I believe it is a major issue, but it is something to
consider too.

Hence my -1

-- 
regards,

Kalle Sommer Nielsen
kalle@php.net