Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95879
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.218.44 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <514c8f81-e411-8278-6c35-aa563ffbaae8@fleshgrinder.com>
References: <CAA69SC5w-0KAGcX_akmhtFJL=mte+3ZrShKPtnWgcML+z-HhKw@mail.gmail.com>
 <F1628C35-24A8-417C-BE40-EBC8F8CE8A14@fredemmott.co.uk> <CAA69SC7MuQa06+ubJBx_bfJO_iT1_cTh7PgYD8nVhrXqG71bXA@mail.gmail.com>
 <CAA69SC55RLKRMSyicbLTK8Z577bDgRo1jCCBf4v9KnPoiVZtQQ@mail.gmail.com> <514c8f81-e411-8278-6c35-aa563ffbaae8@fleshgrinder.com>
Date: Fri, 9 Sep 2016 23:26:51 +0200
Message-ID: <CAA69SC7Tt-HiGqO8+gUG7Q7XM2veqrWZSdxKmt=5RpONJeBwqQ@mail.gmail.com>
To: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1141eac80dc86e053c19ce2c
Subject: Re: [PHP-DEV] RFC - Immutable classes
From: marijic.silvio@gmail.com (=?UTF-8?Q?Silvio_Mariji=C4=87?=)

--001a1141eac80dc86e053c19ce2c
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

@Fleshgrinder,

Well since implementation is still underway I think the best ways would be
to wait untill we finish implementation, and then we all can do the review
to make sure everything is in place.

2016-09-09 23:16 GMT+02:00 Fleshgrinder <php@fleshgrinder.com>:

> On 9/9/2016 10:02 PM, Silvio Mariji=C4=87 wrote:
> > It will be patched before this RFC goes into official discussion.
> >
>
> That explains why all the rewritten tests I provided for Reflection fail:
>
> https://github.com/brzuchal/php-src/pull/1
>
> Should I create this PR against another repository? I created it against
> the one that was last posted for review but no clue which would be right
> one to contribute here?!?
>
> --
> Richard "Fleshgrinder" Fussenegger
>
>


--=20
Silvio Mariji=C4=87
Software Engineer
2e Systems

--001a1141eac80dc86e053c19ce2c--