Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95722
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain ohgaki.net designates 180.42.98.130 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAGa2bXaoPLFNBuEabn_iNXnBrHm8etk1m4gc7brDvz-hbyJG9Q@mail.gmail.com>
References: <CAGa2bXaoPLFNBuEabn_iNXnBrHm8etk1m4gc7brDvz-hbyJG9Q@mail.gmail.com>
Date: Wed, 7 Sep 2016 18:19:46 +0900
Message-ID: <CAGa2bXbvTGDJWR3Ji5Lty5g9p91rruQScnmdb4AxHDk44LGPSA@mail.gmail.com>
To: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: PHP_INI_MH()'s new_value_length being non-zero for NULL new_value?
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

On Wed, Sep 7, 2016 at 5:46 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
> I realized that setting default_charset does not set
> *.internal_encoding/etc. So I looked into what's wrong and found
>
> PHP_INI_MH()'s new_value_length being non-zero for NULL new_value.
>
> This makes fail to set proper value for *.intermal_encoding/etc. This
> happens from PHP 5.6 branch. It was 0 for null value otherwise
> encoding setting was not working from the beginning.
>
> Is this change intended or a bug?
> Or I got zero length during patch development by accident?
>
> If this behavior wouldn't be changed, I'll just commit patch that fix
> the encoding INI issue.

It seems it was by accident. new_value_length would be uninitialized
value because of

PHPAPI zval *cfg_get_entry(const char *name, uint name_length)
{
  zval *tmp;

  if (zend_hash_find(&configuration_hash, name, name_length, (void **)
&tmp) == SUCCESS) {
    return tmp;
  } else {
    return NULL;
  }
}

when there is no ini definition at all.

I'll just fix code inside PHP_INI_MH().

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net