Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95675
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.178 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CANaX5nfXDJEMVqBG499QBG1XYXtkeAXNQk0GQJwdoh11uoMxmw@mail.gmail.com>
References: <CAOWwgpkOGGAiPm2jxQAOYx_ViPToTJSgFYPeaquJXBLgJj2X_g@mail.gmail.com>
 <CAMUwpuTS8XNvdaYsoMSpcbJBnikV079ECuSDzN3VcUQ2jYFaYg@mail.gmail.com>
 <CAOWwgpnE=zGTaZSkvC7wa4qCT+bMLSMgu+a+tpaNvge9xTB3WA@mail.gmail.com>
 <CAMUwpuS5SSzhSVM-cZYoNin3x1fuCyyExeTzNarhO8Cw8CCm1Q@mail.gmail.com>
 <CAMUwpuT1iq7kY5GPr9A=SxhV8oi0_EbEZq7Z3x82RFxKg4nc4w@mail.gmail.com>
 <CAEZPtU5-+xoj+J-5_VbAz1dq4NYVGmCvE1EsL3Gh0yT=w_oD4g@mail.gmail.com>
 <CAOWwgp=BnB5k0F4Kbkg982PcKcOg3u0gwqFiLxZk8dkhqVvy6w@mail.gmail.com>
 <CANUQDCjgqGqLRF9n-WHZk9AnN31snzZQzZfQKbQBxPbAPv_Uzg@mail.gmail.com>
 <CAOWwgpm=koshFAWjMD9DSPXu47JC=SLAuzTsabHW0Jp9PYVgtQ@mail.gmail.com> <CANaX5nfXDJEMVqBG499QBG1XYXtkeAXNQk0GQJwdoh11uoMxmw@mail.gmail.com>
Date: Mon, 5 Sep 2016 22:38:08 +0200
Message-ID: <CAF+90c-T4Ff2jhhsdATFcr_tttML47Jurqb3sxaELnb+E701uw@mail.gmail.com>
To: Davey Shafik <davey@php.net>
Cc: Nicolas Grekas <nicolas.grekas@gmail.com>, Niklas Keller <me@kelunik.com>, 
	Pierre Joye <pierre.php@gmail.com>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11428114730ca7053bc8a80c
Subject: Re: [PHP-DEV] Missing reflection info about strict types?
From: nikita.ppv@gmail.com (Nikita Popov)

--001a11428114730ca7053bc8a80c
Content-Type: text/plain; charset=UTF-8

On Mon, Sep 5, 2016 at 10:30 PM, Davey Shafik <davey@php.net> wrote:

> On Mon, Sep 5, 2016 at 1:13 PM, Nicolas Grekas <nicolas.grekas@gmail.com>
> wrote:
>
> > > Why do you concatenate these files in the first place?
> > >
> > >
> >
> > It's not specifically me but Symfony's ClassCollectionLoader::load()
> > method, which generates a single file with common classes inlined for
> > faster bootstrapping (the perf gain is objectively measurable).
> >
> > You give this method a list of classes that are always required, and it
> > computes all the required parents/interfaces/traits they use, by using
> > reflection of course. It turns namespace to the bracketed syntax, orderd
> > things as required (parents first), and dumps everything in one php file.
> >
> > The issue came to our tracker that this process was broken once one
> wanted
> > to inline a strict class there, either directly or indirectly through the
> > parent chain.
> >
>
> Again, there is not such thing as a strict class. You should be stripping
> ALL declare(strict_types=0/1) from the class files, and even if enabled it
> at the top of final generated file it wouldn't make any difference _unless_
> you're calling the classes IN the generated file. Anything you include it
> into will decide for itself whether it is strict or not.
>

Stripping strict_types declaration will change the behavior of the code
declared *within those files* (not the code calling that code). The
behavior should not change in the merge process.

As I see it, the issue here is really not how to figure out whether a file
uses strict_types, the issue is how you mix strict_types=1 and
strict_types=0 code in a single file.

Back when this feature was introduced, we decided not to allow this kind of
mixing, as it seemed prone to causing a mess and use-cases seemed doubtful.
Given the issue Symfony is experiencing, we should reevaluate this
decision. Imho it's not good if there are some things you simply *cannot*
express in a single file.

Nikita

--001a11428114730ca7053bc8a80c--