Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95674
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain daveyshafik.com from 209.85.220.175 cause and error)
MIME-Version: 1.0
Sender: me@daveyshafik.com
In-Reply-To: <CAOWwgpm=koshFAWjMD9DSPXu47JC=SLAuzTsabHW0Jp9PYVgtQ@mail.gmail.com>
References: <CAOWwgpkOGGAiPm2jxQAOYx_ViPToTJSgFYPeaquJXBLgJj2X_g@mail.gmail.com>
 <CAMUwpuTS8XNvdaYsoMSpcbJBnikV079ECuSDzN3VcUQ2jYFaYg@mail.gmail.com>
 <CAOWwgpnE=zGTaZSkvC7wa4qCT+bMLSMgu+a+tpaNvge9xTB3WA@mail.gmail.com>
 <CAMUwpuS5SSzhSVM-cZYoNin3x1fuCyyExeTzNarhO8Cw8CCm1Q@mail.gmail.com>
 <CAMUwpuT1iq7kY5GPr9A=SxhV8oi0_EbEZq7Z3x82RFxKg4nc4w@mail.gmail.com>
 <CAEZPtU5-+xoj+J-5_VbAz1dq4NYVGmCvE1EsL3Gh0yT=w_oD4g@mail.gmail.com>
 <CAOWwgp=BnB5k0F4Kbkg982PcKcOg3u0gwqFiLxZk8dkhqVvy6w@mail.gmail.com>
 <CANUQDCjgqGqLRF9n-WHZk9AnN31snzZQzZfQKbQBxPbAPv_Uzg@mail.gmail.com> <CAOWwgpm=koshFAWjMD9DSPXu47JC=SLAuzTsabHW0Jp9PYVgtQ@mail.gmail.com>
Date: Mon, 5 Sep 2016 13:30:02 -0700
Message-ID: <CANaX5nfXDJEMVqBG499QBG1XYXtkeAXNQk0GQJwdoh11uoMxmw@mail.gmail.com>
To: Nicolas Grekas <nicolas.grekas@gmail.com>
Cc: Niklas Keller <me@kelunik.com>, Pierre Joye <pierre.php@gmail.com>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1149a728767a7f053bc88bc0
Subject: Re: [PHP-DEV] Missing reflection info about strict types?
From: davey@php.net (Davey Shafik)

--001a1149a728767a7f053bc88bc0
Content-Type: text/plain; charset=UTF-8

On Mon, Sep 5, 2016 at 1:13 PM, Nicolas Grekas <nicolas.grekas@gmail.com>
wrote:

> > Why do you concatenate these files in the first place?
> >
> >
>
> It's not specifically me but Symfony's ClassCollectionLoader::load()
> method, which generates a single file with common classes inlined for
> faster bootstrapping (the perf gain is objectively measurable).
>
> You give this method a list of classes that are always required, and it
> computes all the required parents/interfaces/traits they use, by using
> reflection of course. It turns namespace to the bracketed syntax, orderd
> things as required (parents first), and dumps everything in one php file.
>
> The issue came to our tracker that this process was broken once one wanted
> to inline a strict class there, either directly or indirectly through the
> parent chain.
>

Again, there is not such thing as a strict class. You should be stripping
ALL declare(strict_types=0/1) from the class files, and even if enabled it
at the top of final generated file it wouldn't make any difference _unless_
you're calling the classes IN the generated file. Anything you include it
into will decide for itself whether it is strict or not.


> I worked on the issue and fixed it by replacing the inlining by a "require"
> for now.
>
> Here is the pointer for the fix (then the class & the issue):
> https://github.com/symfony/symfony/pull/19859/files?w=1


I would highly recommend using sprintf() instead of str_replace() to inject
your regex. And again, strip the declare lines completely. Then you can
concat.

https://github.com/symfony/symfony/pull/19859/files?w=1#diff-e37b3a45b919f2dd526570353388e4a5R1

This isn't a class with strict types, it's a file that will enforce strict
types on code that _it_ calls, not code that calls the class defined inside
it.

- Davey

--001a1149a728767a7f053bc88bc0--