Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95668
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.54 as permitted sender)
MIME-Version: 1.0
Sender: julienpauli@gmail.com
In-Reply-To: <A2.D5.45301.28DADC75@pb1.pair.com>
References: <CAOWwgpkOGGAiPm2jxQAOYx_ViPToTJSgFYPeaquJXBLgJj2X_g@mail.gmail.com>
 <CAMUwpuTS8XNvdaYsoMSpcbJBnikV079ECuSDzN3VcUQ2jYFaYg@mail.gmail.com>
 <CAOWwgpnE=zGTaZSkvC7wa4qCT+bMLSMgu+a+tpaNvge9xTB3WA@mail.gmail.com> <A2.D5.45301.28DADC75@pb1.pair.com>
Date: Mon, 5 Sep 2016 20:41:21 +0200
Message-ID: <CAMUwpuRQkY=ndqX8ngYHNTyjwf-MO4w6qau+S-khokFFOu=N7A@mail.gmail.com>
To: Andrea Faulds <ajf@ajf.me>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Missing reflection info about strict types?
From: jpauli@php.net (Julien Pauli)

On Mon, Sep 5, 2016 at 7:38 PM, Andrea Faulds <ajf@ajf.me> wrote:
> Hi,
>
> Nicolas Grekas wrote:
>>
>> Thanks for trying Julien
>>
>> I guess what you miss for what you want to do, is to detect if strict
>>>
>>> types are activated into the current scope, at runtime.
>>>
>>
>>  From the inside, the author of the code knows if they added the declare
>> or
>> not.
>> I'd need to know from the outside, before concatenating it, if some file
>> has strict types.
>> This could be exposed on the reflection, since a function/method/class
>> could have a flag that tells if it has been compiled with strict types
>> enabled or not.
>> The current alternative is to parse the source to check if it starts wit=
h
>> the declare directive (but not trivial because of non semantic tokens).
>>
>> Here is my current regex to do so:
>>>
>>> $c =3D '(?:\s*+(?:(?:#|//)[^\n]*+\n|/\*(?:(?<!\*/).)++)?+)*+';
>>> $strictTypesRegex =3D str_replace('.', $c, "'^<\?php\s.declare.\(.stric=
t_
>>
>> types.=3D.1.\).;'is");
>
>
> Reflection deals with classes, functions, and so on, but it doesn't deal
> with files. Files are, for the most part, a detail that is only represent=
ed
> when code is compiled (e.g. when an include or require statement is run, =
or
> when a script is executed by a request or from the command line). After t=
hat
> compilation stage, however, there's no structure for a =E2=80=9Cfile=E2=
=80=9D in memory
> (beyond maybe in OPcache). The constants, functions, classes and variable=
s
> it defines are kept track of by the PHP interpreter, but the file itself
> isn't directly.
>
> Because of this, implementing a reflection method to tell you whether a f=
ile
> uses the strict_types directive isn't currently possible. To the best of =
my
> knowledge, PHP doesn't maintain a registry of files in memory which track=
s
> whether they use strict typing or not. Instead it marks any code originat=
ing
> from strictly-typed files as using strict mode.
>
> I suppose the PHP interpreter could be modified so it kept track of this
> information. Though, if you're concatenating arbitrary source files, I fe=
el
> like reflection might be the wrong tool to use. I think reflection is mor=
e
> intended for inspecting your own codebase, rather than analysing arbitrar=
y
> PHP files. In order to use reflection on some PHP file, you have to inclu=
de
> it first, and you can't un-include it later. You also can't prevent any
> top-level PHP code in that file from executing when you include it.
>
> If you don't need to know whether a /file/ specifically uses strict typin=
g,
> and only need to know which classes do, that might be possible, given PHP
> does know at runtime which methods use strict typing. Again, though, I'm =
not
> sure if reflection is the best tool.
>
> Your best hope is probably to try and parse the file using PHP-Parser or =
the
> Tokenizer extension.
>
> I hope this is helpful.

I have to both, confirm and agree.


Julien