Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95646
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain kelunik.com from 81.169.146.219 cause and error)
MIME-Version: 1.0
In-Reply-To: <CAMUwpuT1iq7kY5GPr9A=SxhV8oi0_EbEZq7Z3x82RFxKg4nc4w@mail.gmail.com>
References: <CAOWwgpkOGGAiPm2jxQAOYx_ViPToTJSgFYPeaquJXBLgJj2X_g@mail.gmail.com>
 <CAMUwpuTS8XNvdaYsoMSpcbJBnikV079ECuSDzN3VcUQ2jYFaYg@mail.gmail.com>
 <CAOWwgpnE=zGTaZSkvC7wa4qCT+bMLSMgu+a+tpaNvge9xTB3WA@mail.gmail.com>
 <CAMUwpuS5SSzhSVM-cZYoNin3x1fuCyyExeTzNarhO8Cw8CCm1Q@mail.gmail.com> <CAMUwpuT1iq7kY5GPr9A=SxhV8oi0_EbEZq7Z3x82RFxKg4nc4w@mail.gmail.com>
Date: Mon, 5 Sep 2016 16:19:46 +0200
Message-ID: <CANUQDCiyEMszRv_oPyp1AzgeUREy1zerJrx31v3gSNL84ixp3Q@mail.gmail.com>
To: Julien Pauli <jpauli@php.net>
Cc: Nicolas Grekas <nicolas.grekas@gmail.com>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e01493f5e4e143e053bc35ff8
Subject: Re: [PHP-DEV] Missing reflection info about strict types?
From: me@kelunik.com (Niklas Keller)

--089e01493f5e4e143e053bc35ff8
Content-Type: text/plain; charset=UTF-8

2016-09-05 15:52 GMT+02:00 Julien Pauli <jpauli@php.net>:

> On Mon, Sep 5, 2016 at 3:19 PM, Julien Pauli <jpauli@php.net> wrote:
> > On Mon, Sep 5, 2016 at 2:44 PM, Nicolas Grekas <nicolas.grekas@gmail.com>
> wrote:
> >> Thanks for trying Julien
> >>
> >>> I guess what you miss for what you want to do, is to detect if strict
> >>> types are activated into the current scope, at runtime.
> >>
> >>
> >> From the inside, the author of the code knows if they added the declare
> or
> >> not.
> >> I'd need to know from the outside, before concatenating it, if some
> file has
> >> strict types.
> >> This could be exposed on the reflection, since a function/method/class
> could
> >> have a flag that tells if it has been compiled with strict types
> enabled or
> >> not.
> >> The current alternative is to parse the source to check if it starts
> with
> >> the declare directive (but not trivial because of non semantic tokens).
> >>
> >
> > Then you need reflection.
> >
> > I just added ReflectionClass:isStrictlyTyped() and
> > ReflectionFunction::isStrictlyTyped() to my patch
> >
> > https://github.com/jpauli/php-src/tree/is_strict
> <https://github.com/jpauli/php-src/tree/is_strict_types>


>
> *Julien*


> *--*

*PHP Internals - PHP Runtime Development Mailing List*

*To unsubscribe, visit: http://www.php.net/unsub.php
> <http://www.php.net/unsub.php>*

_types <https://github.com/jpauli/php-src/tree/is_strict_types>
>
> Any souls to +1 the reflection patch ?


ReflectionFunction::isStrictlyTyped doesn't make sense. As mentioned
already, this doesn't depend on the function declaration but on the CALLER
instead.

Regards, Niklas

--089e01493f5e4e143e053bc35ff8--