Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95626
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain brzuchalski.com designates 188.165.245.118 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <642a6e78-90ea-cbf0-ec1c-376c24e568c5@fleshgrinder.com>
References: <CAA69SC5w-0KAGcX_akmhtFJL=mte+3ZrShKPtnWgcML+z-HhKw@mail.gmail.com>
 <CAA69SC71Zx4ooS2pNnH+aSR+D1fxxtFA+zfZLKpFVvUh635t1g@mail.gmail.com>
 <4f54308a-4a69-2e6b-2ed0-51d4336d1cd4@fleshgrinder.com> <5969d1af-48e5-1376-07fe-9568de538145@texthtml.net>
 <CABdc3Wp13y2bjC-T3PuiXLvN_3rvenQ3J9f0562+xu4Yij70wg@mail.gmail.com>
 <CAA69SC45Qva3-fky+P_Bbq2rw9F5ThJQ7NzbANa2ZpZFXvMOXw@mail.gmail.com>
 <A722888E-EB21-4467-A5C0-3201A6773E1D@ez.no> <CAA69SC48nvQ9n6h088LsQ=zzo-z07fH31MQKzh9k5TFh7KGLKw@mail.gmail.com>
 <f5af9b78-eac0-651f-6740-6b5f1f0803a8@garfieldtech.com> <CABdc3Wpk-PypKgOjr4yUj+gyfFkssbL=fusqaUoH4-y6SbO+5w@mail.gmail.com>
 <CAA69SC5BAK5U0iGLZDQ084HjnWpxZiCDXWV_dDLcern_=2WiPg@mail.gmail.com>
 <CABHuAWx64sz44LvQ0ONU5cDa7mAgwYnCUL2CPco2reOAs0EaPg@mail.gmail.com>
 <0e71d28e-1d64-5372-b58d-e54c7afae3b8@fleshgrinder.com> <CABdc3WoGW11+x7OLWSxEpzqc3-c2MSTC8CWVfUpybdqNzbQRBA@mail.gmail.com>
 <CABdc3WqGZ9GML-jb31FPudkML9eojpJ-Ap3kPsyd_5d8_fnwAQ@mail.gmail.com> <642a6e78-90ea-cbf0-ec1c-376c24e568c5@fleshgrinder.com>
Date: Mon, 5 Sep 2016 04:21:46 +0200
Message-ID: <CABdc3WqGFyM23CNA0eaMAyCn8L0=TaUf3xSoBOsFY_Gz4Z5uGA@mail.gmail.com>
To: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a113eddc28c9999053bb957fd
Subject: Re: [PHP-DEV] RFC - Immutable classes
From: michal@brzuchalski.com (=?UTF-8?Q?Micha=C5=82_Brzuchalski?=)

--001a113eddc28c9999053bb957fd
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

2016-09-04 22:38 GMT+02:00 Fleshgrinder <php@fleshgrinder.com>:

> On 9/4/2016 2:29 PM, Micha=C5=82 Brzuchalski wrote:
> >> Providing `mutator` | `mut` keyword as method modifier sounds liek a
> good
> >> idea,
> >> althought passing `$clone` parameter as first additional param could
> break
> >> method declaration and would be misleading.
> >>
> >> Assuming mutator method is designed to  return mutated clone of
> immutable
> >> object
> >> having `$clone` variable could be handled internally without breaking
> >> method declaration.
> >>
> >> Such variable could be unlocked while in mutator method and locked on
> >> return.
> >> I was thinking about additional check if such mutator returns `$clone`
> but
> >> not `$this`
> >> but I don't see the need of it - assuming there is no what to change i=
n
> >> some
> >> circumstances ther would be also possible to return `$this`.
> >>
> >> The return type declaration `self` could increase readability, but
> should
> >> not be required,
> >> as some developers doesn't already use return types.
> >>
> >
> > It could look like in this gist
> > https://gist.github.com/brzuchal/e7b721e22a19cca42ec0d1f597a23baf
> >
>
> This is exactly how I meant it, yes. I actually prefer it if the
> variable just exist in the context instead of passing it as first
> argument. It's less obvious that it exists but the same could be said
> about $this.
>
> Would it be possible to have this thing just in time instead of
> automatically created in every mutator function?
>
>   public mutator function f() {
>     if (condition) {
>       $clone is created;
>       return $clone;
>     }
>     return $this;
>   }
>
> PS: I started overhauling the test cases and error messages and will
> create a PR against your branch soon. I will start with the RFC
> afterwards. Should I simply edit the RFC in the Wiki or should we manage
> this somewhere else?
>
>
You may begin with modifications on RFC eg. in a gist so we can all discuss
about it before putting on RFC, is that okay to you?


> --
> Richard "Fleshgrinder" Fussenegger
>
>


--=20
regards / pozdrawiam,
--
Micha=C5=82 Brzuchalski
brzuchalski.com

--001a113eddc28c9999053bb957fd--