Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95557
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.179 as permitted sender)
To: internals@lists.php.net
References: <CAGa2bXarw2jTj0yhXpywWNQOJLR2pdhfaqSdwj_btT2giEL15Q@mail.gmail.com>
 <CAGa2bXaA+uvh_wpRAHeiv+Xb-JOrTAkyoe3jzq3FVCEbfja_5w@mail.gmail.com>
 <232F1604-2211-4351-B830-EDC958A25D6D@strojny.net>
 <CAGa2bXb2y4afY28rwdcjgxUEkr41ZPMMdj4dUtMDVtJLBONAbA@mail.gmail.com>
 <2de35db0-9974-cc96-83dd-3d2dbd48f7f8@lsces.co.uk>
 <CAGa2bXYG1Or9+SGf3Rm4Yi5KUQ1mwnffTSSzuwARpy4bFfXB=w@mail.gmail.com>
Message-ID: <5b72e9da-068a-bc79-82c2-f36f723f42bb@gmail.com>
Date: Fri, 2 Sep 2016 11:37:48 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <CAGa2bXYG1Or9+SGf3Rm4Yi5KUQ1mwnffTSSzuwARpy4bFfXB=w@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC][VOTE] Add validation functions to filter module
From: rowan.collins@gmail.com (Rowan Collins)

On 02/09/2016 11:11, Yasuo Ohgaki wrote:
> Taking care of tampered data by business logic will reduce both
> readability and maintainability. And more importantly, make code
> less secure because programmers tend to focus on logic
> in model, not input data validations.

This certainly makes sense. I guess the challenge is that in order to 
know if data has been tampered, you need to have some knowledge of the 
expected format. That expectation depends on what data you're expecting, 
which depends - ultimately - on the domain objects being modelled.

More specifically, though, it depends on the interaction design - in an 
HTML context, the forms being presented. So the validation needs 
knowledge of the form controls - e.g. if a select box was shown, and the 
value is not from the known list of options, the input has been tampered 
with.

If that's the case, the logical place to build the validation is into a 
form builder. At which point you've probably got a complex architecture 
in userland, and filter_* functions are unlikely to be a natural fit.

If somebody's *not* using a library to build the form (e.g. they're 
laying out the HTML by hand), are they likely to set up the complex 
validation settings needed by the filter_* functions?

Regards,
-- 
Rowan Collins
[IMSoP]